Conversation
…InstallPath check
There was a problem hiding this comment.
Pull request overview
This pull request addresses issue #3077 where users were seeing warning messages about "Revit IFC 2022" and similar addins when opening Revit. The issue occurs because Revit addins (like "Revit IFC") are registered in the Windows registry under the same uninstall key as actual Revit installations, matching the regex pattern used to detect Revit products, but lacking an InstallLocation value.
Changes:
- Added null check for
regInstallPathto skip registry entries without an install location (typically addins) - Demoted log level from
WarntoDebugfor messages about products that cannot be determined, reducing noise in user-facing logs
Comments suppressed due to low confidence (1)
dev/pyRevitLabs/pyRevitLabs.TargetApps.Revit/RevitProduct.cs:292
- Condition is always true because of ... == ....
if (regInstallPath != null && regInstallPath != string.Empty)
Refactor registry key handling for Revit products to improve error handling for missing or invalid language codes. as per #3081 (comment)
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26036+2010-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26036+2016-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2007-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2031-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2041-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26044+0650-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26046+2000-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0654-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0653-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0702-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+1948-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2011-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2110-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2131-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2147-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2248-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26047+2255-wip |
|
📦 New public release are available for 6.1.0.26047+2349 |
Added an extra check for the registry key and demoted the logger from Warn to Debug.