Skip to content

Update pick_point() in pyrevitlib\pyrevit\revit\selection.py#3080

Merged
jmcouffin merged 1 commit intopyrevitlabs:developfrom
Denver-22:develop
Feb 5, 2026
Merged

Update pick_point() in pyrevitlib\pyrevit\revit\selection.py#3080
jmcouffin merged 1 commit intopyrevitlabs:developfrom
Denver-22:develop

Conversation

@Denver-22
Copy link
Copy Markdown
Contributor

The absence of reference planes in Drafting Views and Legends has been taken into account.

The absence of reference planes in Drafting Views and Legends has been taken into account.
@Denver-22
Copy link
Copy Markdown
Contributor Author

Denver-22 commented Feb 5, 2026

@jmcouffin jmcouffin requested a review from Copilot February 5, 2026 06:50
@pyrevitlabs pyrevitlabs deleted a comment from devloai bot Feb 5, 2026
@jmcouffin jmcouffin self-assigned this Feb 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes an issue in the pick_point() function where it incorrectly attempted to create a temporary sketch plane for Drafting Views and Legend views, which don't support reference planes/sketch planes.

Changes:

  • Added a check to exclude DB.ViewType.DraftingView and DB.ViewType.Legend from automatic sketch plane creation
  • Introduced a tuple constant NO_SKETCHPLANE_VIEWTYPES to define view types that don't support sketch planes
  • Replaced the simple if active_view.SketchPlane is None condition with a compound needs_plane variable that accounts for view type

@jmcouffin jmcouffin merged commit 62f74a1 into pyrevitlabs:develop Feb 5, 2026
6 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26036+1355-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26036+2010-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26036+2016-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2007-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2031-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2041-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26044+0650-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26046+2000-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0654-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0653-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0702-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+1948-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2011-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2110-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2131-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2147-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2248-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.1.0.26047+2255-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New public release are available for 6.1.0.26047+2349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants