Conversation
Co-authored-by: jmcouffin <jmcouffin@gmail.com>
|
Cursor Agent can help with this pull request. Just |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@romangolev this should fix https://discourse.pyrevitlabs.io/t/did-panel-coloring-change/9849 |
|
@jmcouffin should be good to go. LGTM |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26034+0648-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26036+1355-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26036+2010-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26036+2016-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2007-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2031-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2041-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26044+0650-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26046+2000-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0654-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0653-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0702-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+1948-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2011-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2110-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2131-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2147-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2248-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26047+2255-wip |
|
📦 New public release are available for 6.1.0.26047+2349 |
Restore Panel Background Colors in C# Loader
Description
This PR addresses an issue where custom panel background colors were not being applied by the C# loader. The problem stemmed from a lookup mismatch in
PanelStyleManager.cs, where Autodesk.Windows tabs and panels were being searched for byIdonly, while they were often identified by theirTitle.The fix updates the lookup logic to match tabs by
TitleorId, and panels bySource.TitleorSource.Id. This change aligns the C# loader's behavior with the Python implementation, ensuring that panel background colors defined inbundle.yamlare correctly applied to the Revit UI.Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request:
Additional Notes
This change directly addresses a user report of missing panel background colors. While formal UI tests are not part of this repository's test suite, the fix targets the identified lookup discrepancy. Users should ensure their
bundle.yamldefinesbackgroundusing hex#RRGGBBor#AARRGGBBvalues.Thank you for contributing to pyRevit! 🎉