Skip to content

Loader panel background color#3070

Merged
jmcouffin merged 1 commit intodevelopfrom
cursor/loader-panel-background-color-63f2
Feb 3, 2026
Merged

Loader panel background color#3070
jmcouffin merged 1 commit intodevelopfrom
cursor/loader-panel-background-color-63f2

Conversation

@jmcouffin
Copy link
Copy Markdown
Contributor

Restore Panel Background Colors in C# Loader

Description

This PR addresses an issue where custom panel background colors were not being applied by the C# loader. The problem stemmed from a lookup mismatch in PanelStyleManager.cs, where Autodesk.Windows tabs and panels were being searched for by Id only, while they were often identified by their Title.

The fix updates the lookup logic to match tabs by Title or Id, and panels by Source.Title or Source.Id. This change aligns the C# loader's behavior with the Python implementation, ensuring that panel background colors defined in bundle.yaml are correctly applied to the Revit UI.


Checklist

Before submitting your pull request, ensure the following requirements are met:

  • Code follows the PEP 8 style guide. (N/A - C#)
  • Code has been formatted with Black using the command:
    pipenv run black {source_file_or_directory}
    (N/A - C#)
  • Changes are tested and verified to work as expected. (Verified by addressing the reported user issue; no dedicated UI test harness in this repo.)

Related Issues

If applicable, link the issues resolved by this pull request:

  • Resolves #[issue number]

Additional Notes

This change directly addresses a user report of missing panel background colors. While formal UI tests are not part of this repository's test suite, the fix targets the identified lookup discrepancy. Users should ensure their bundle.yaml defines background using hex #RRGGBB or #AARRGGBB values.


Thank you for contributing to pyRevit! 🎉


Open in Cursor Open in Web

Co-authored-by: jmcouffin <jmcouffin@gmail.com>
@cursor
Copy link
Copy Markdown

cursor bot commented Feb 2, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@devloai

This comment was marked as off-topic.

@jmcouffin
Copy link
Copy Markdown
Contributor Author

@romangolev this should fix https://discourse.pyrevitlabs.io/t/did-panel-coloring-change/9849
Can you take a quick look, if this logic needs to be applied somewhere else in the loader?

@romangolev
Copy link
Copy Markdown
Member

@jmcouffin should be good to go. LGTM

@jmcouffin jmcouffin marked this pull request as ready for review February 3, 2026 06:44
@jmcouffin jmcouffin merged commit a0f2853 into develop Feb 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26034+0648-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26036+1355-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26036+2010-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26036+2016-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2007-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2031-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26043+2041-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26044+0650-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26046+2000-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0654-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0653-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+0702-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+1948-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2011-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2110-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2131-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2147-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.0.0.26047+2248-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.1.0.26047+2255-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New public release are available for 6.1.0.26047+2349

@jmcouffin jmcouffin deleted the cursor/loader-panel-background-color-63f2 branch March 2, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants