Skip to content

SCCM / SYSTEM — run all admin installer steps as installer account#3051

Merged
jmcouffin merged 2 commits intodevelopfrom
sccm-system-attach
Feb 1, 2026
Merged

SCCM / SYSTEM — run all admin installer steps as installer account#3051
jmcouffin merged 2 commits intodevelopfrom
sccm-system-attach

Conversation

@jmcouffin
Copy link
Copy Markdown
Contributor

@jmcouffin jmcouffin commented Feb 1, 2026

What

Admin installer: run all post-install and uninstall steps as the installing account (no runascurrentuser), so when deployed as SYSTEM (e.g. SCCM) every step can succeed and write to all-users / ProgramData.

File: release/pyrevit-admin.iss
Change: Remove runascurrentuser from all [Run] and [UninstallRun] entries (keep runhidden). Aligns with the per-user installer (pyrevit.iss), which uses only runhidden for these steps.

Why

Fixes #2923 — pyRevit installed via SCCM (Windows System account) should show as attached for all users.

Under SCCM the installer runs as SYSTEM; there is no interactive "current user." With runascurrentuser, every step (caches clear, detach, clones add, attach) could skip or run in a broken context. Running all steps as the installer (SYSTEM) ensures:

  • clones add registers the master in ProgramData (all-users config).
  • attach creates the .addin in the all-users Revit Addins folder so every user sees the pyRevit tab.
  • Uninstall: caches clear and detach run as SYSTEM so SCCM uninstall cleans up correctly.

Verification

  • SCCM / psexec -s: Run admin installer as SYSTEM. As a normal user run pyrevit attached — should list the attachment (master | AllUsers | path). Revit should show the pyRevit tab. Uninstall as SYSTEM; all-users .addin and caches should be cleaned.
  • Interactive admin: Run admin installer as administrator. All steps run as admin; normal users should see the attachment.
  • Per-user installer: Unchanged; no edits to release/pyrevit.iss.

@jmcouffin jmcouffin requested a review from Copilot February 1, 2026 15:56
@jmcouffin jmcouffin self-assigned this Feb 1, 2026
@jmcouffin jmcouffin added the Installer Issues related to the pyRevit installer [subsystem] label Feb 1, 2026

This comment was marked as outdated.

devloai[bot]

This comment was marked as outdated.

@jmcouffin jmcouffin changed the title SCCM / SYSTEM attach — run attach step as installer account SCCM / SYSTEM — run all admin installer steps as installer account Feb 1, 2026
@jmcouffin jmcouffin merged commit a998cbb into develop Feb 1, 2026
@jmcouffin jmcouffin deleted the sccm-system-attach branch February 1, 2026 16:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1612-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1624-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1738-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1743-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1829-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1937-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+1956-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2005-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2008-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New public release are available for 6.0.0.26032+2040

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New public release are available for 6.0.0.26032+2040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Installer Issues related to the pyRevit installer [subsystem]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: installing pyRevit admin exe through SCCM does not attach to Revit properly

2 participants