Conversation
…s parameter handling - Removed unnecessary elevation check in GetRevitAddonsFilePath method. - Updated unit tests to verify behavior of GetRevitAddonsFilePath with allusers parameter for different Revit versions. - Ensured paths are correctly returned based on user and allusers settings.
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1538-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1543-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1553-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1612-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1624-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1738-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1743-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1829-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1937-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26032+1956-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2005-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2008-wip |
|
📦 New public release are available for 6.0.0.26032+2040 |
|
📦 New public release are available for 6.0.0.26032+2040 |
fixes: #2611
1.1 – GetRevitAddonsFilePath (RevitAddons.cs)
allusers = truewhen running elevated.GetRevitAddonsFolder(revitYear, allUsers: allusers).GetRevitAddonsFilePathnow only uses the allusers parameter; elevation no longer overrides it.1.2 – Admin installer (pyrevit-admin.iss)
"attach master default --installed"
to
"attach master default --installed --allusers".
1.3 – Per-user installer (pyrevit.iss)
Confirmed the attach [Run] line is
Parameters: "attach master default --installed"(no
--allusers). No change made.1.5 – Unit tests (pyRevitLabs.UnitTests.RevitAddons.cs)
Existing tests already use
allusers: falseand do not rely on elevation overriding allusers; no changes needed there.Added
GetRevitAddonsFilePath_ExplicitAllUsers_Test:allusers: false→ path containsAppDataorRoaming.-
allusers: truefor 2026 → path underCommonApplicationData.allusers: truefor 2027 → path containsAddinsand2027and ends withTestAddin.addin.Verification
dotnet build pyRevitLabs.sln -c Releasecompleted successfully (0 errors; existing SYSLIB0014 warnings only).Behavior
.addingoes to user scope:%AppData%\...\Revit\Addins\<YEAR>\.addingoes to all-users scope (ProgramData for Revit ≤2026, Revit install path for 2027+), because the post-install step uses--allusers