Skip to content

fix: minor compat for 2027#3041

Merged
jmcouffin merged 1 commit intodevelopfrom
2027-fixes
Feb 1, 2026
Merged

fix: minor compat for 2027#3041
jmcouffin merged 1 commit intodevelopfrom
2027-fixes

Conversation

@jmcouffin
Copy link
Copy Markdown
Contributor

  • Updated the spelling of "PressureLossReport" to "PresureLossReport" to match API naming.
  • ntroduced a base list of valid view types and conditionally included optional view types based on their availability in the current Revit version.
  • Adjusted calculations for view counts to account for the optional nature of certain view types.I

... keeping this open for future fixes

…_all_check.py

- Updated the spelling of "PressureLossReport" to "PresureLossReport" to match API naming.
- ntroduced a base list of valid view types and conditionally included optional view types based on their availability in the current Revit version.
- Adjusted calculations for view counts to account for the optional nature of certain view types.I
@pyrevitlabs pyrevitlabs deleted a comment from devloai bot Jan 30, 2026
@jmcouffin jmcouffin requested a review from Copilot January 30, 2026 22:49
@jmcouffin jmcouffin self-assigned this Jan 30, 2026
@jmcouffin jmcouffin added the API Change Revit API change that breaks pyRevit [class->Upgraded #{number}: {title}] label Jan 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes minor compatibility and documentation adjustments for Revit 2027, focusing on optional view types and aligning naming with the Revit API. It ensures the audit check script remains loadable and accurate across Revit versions where certain view types may be removed.

Changes:

  • Clarified the ViewFamily docstring to note the API’s PresureLossReport spelling.
  • Refactored the audit_all_check view-type lists to use a stable base set and conditionally include PresureLossReport and SystemsAnalysisReport only when available on the running Revit version.
  • Updated view count calculations to reference optional view types through guarded module-level variables, avoiding attribute errors on newer versions where those types are absent.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pyrevitlib/rpw/db/view.py Updates ViewFamily documentation to explicitly reflect the API’s PresureLossReport spelling while clarifying its meaning.
extensions/pyRevitTools.extension/checks/audit_all_check.py Makes PresureLossReport and SystemsAnalysisReport optional via getattr guards and updates VALID/INVALID view-type handling and view count calculations for cross-version compatibility.

@jmcouffin jmcouffin marked this pull request as draft January 31, 2026 12:49
@jmcouffin jmcouffin marked this pull request as ready for review February 1, 2026 17:38
@jmcouffin jmcouffin merged commit f39af99 into develop Feb 1, 2026
6 checks passed
@jmcouffin jmcouffin deleted the 2027-fixes branch February 1, 2026 17:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1743-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1829-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1937-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+1956-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2005-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2008-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New public release are available for 6.0.0.26032+2040

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New public release are available for 6.0.0.26032+2040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Change Revit API change that breaks pyRevit [class->Upgraded #{number}: {title}]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants