Update pick_point() in pyrevitlib\pyrevit\revit\selection.py by Denver-22 · Pull Request #3018 · pyrevitlabs/pyRevit

Denver-22 · 2026-01-15T12:58:16Z

Implemented the creation of a work plane for the current view. Without this, the PickPoint() function does not work.
This is relevant for ceiling plans, where a work plane is sometimes not assigned during creation.

P.S. The translation for French, German, and Spanish was done using a translator. I apologize for any errors.

Implemented the creation of a work plane for the current view. Without this, the PickPoint() function does not work. This is relevant for ceiling plans, where a work plane is sometimes not assigned during creation.

devloai · 2026-01-15T12:58:20Z

Unable to trigger custom agent "Code Reviewer"You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

pyrevitlib/pyrevit/revit/selection.py

Some fix.

Copilot

Pull request overview

This PR adds automatic work plane (SketchPlane) creation to the pick_point() function in pyrevitlib's selection utilities. The change addresses an issue where PickPoint() fails in views without an assigned work plane, particularly ceiling plans.

Changes:

Adds logic to detect when a view lacks a SketchPlane and automatically creates one based on the view's direction and origin
Implements multi-language support for the transaction name using translations for English, French, German, Spanish, and Russian
Wraps the SketchPlane creation in a transaction to ensure proper database modification

pyrevitlib/pyrevit/revit/selection.py

Some corrections based on comments

Fix 'English_USA' language

To avoid potential future naming conflicts between DB and pyrevit.revit.

jmcouffin · 2026-01-15T17:45:43Z

Please let me know when it is ready for review @Denver-22

Denver-22 · 2026-01-15T19:09:35Z

@jmcouffin, it is ready

… creation and cleanup - Enhanced error handling during SketchPlane creation and deletion. - Added support for Chinese_Simplified translation. - Ensured temporary work planes are removed after use to maintain document integrity.

jmcouffin · 2026-01-17T09:59:28Z

Not that simple in the end..
I did not want the selection to create a transaction commit it without roolback... imagine all these new sketchplanes piling up in all revit files ;p

thks @Denver-22

github-actions · 2026-01-17T10:15:36Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26017+1003-wip

Denver-22 · 2026-01-17T11:43:26Z

@jmcouffin
I understand your idea about eliminating the transaction for creating workplanes. This is the correct solution compared to mine!
But when testing your solution, two transactions are created (there should be zero). Are you getting different results?
I've created a new PR with a solution that implements your idea. Please review it.

github-actions · 2026-01-17T21:20:57Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26017+2108-wip

github-actions · 2026-01-17T21:32:08Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26017+2119-wip

github-actions · 2026-01-22T21:34:19Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2117-wip

github-actions · 2026-01-22T21:42:14Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2124-wip

github-actions · 2026-01-22T21:53:29Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2138-wip

github-actions · 2026-01-23T21:49:58Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2136-wip

github-actions · 2026-01-23T22:00:10Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2141-wip

github-actions · 2026-01-25T13:43:03Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1329-wip

github-actions · 2026-01-25T14:29:50Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1418-wip

github-actions · 2026-01-30T20:49:52Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2037-wip

github-actions · 2026-01-30T20:50:34Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2039-wip

github-actions · 2026-01-30T21:15:19Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2101-wip

github-actions · 2026-01-30T21:48:20Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2136-wip

github-actions · 2026-01-30T22:01:33Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2147-wip

github-actions · 2026-01-30T22:23:30Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2212-wip

github-actions · 2026-02-01T10:55:44Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1043-wip

github-actions · 2026-02-01T11:23:31Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1111-wip

github-actions · 2026-02-01T13:16:31Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1304-wip

github-actions · 2026-02-01T13:35:52Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1323-wip

github-actions · 2026-02-01T14:48:10Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1433-wip

github-actions · 2026-02-01T15:49:59Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1538-wip

github-actions · 2026-02-01T15:56:28Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1543-wip

github-actions · 2026-02-01T16:05:16Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1553-wip

github-actions · 2026-02-01T16:24:21Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1612-wip

github-actions · 2026-02-01T16:38:33Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1624-wip

github-actions · 2026-02-01T17:50:14Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1738-wip

github-actions · 2026-02-01T17:56:15Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1743-wip

github-actions · 2026-02-01T18:44:53Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1829-wip

github-actions · 2026-02-01T19:50:21Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1937-wip

github-actions · 2026-02-01T20:08:05Z

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+1956-wip

github-actions · 2026-02-01T20:16:42Z

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2005-wip

github-actions · 2026-02-01T20:20:28Z

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2008-wip

github-actions · 2026-02-01T20:24:34Z

📦 New public release are available for 6.0.0.26032+2040

github-actions · 2026-02-01T20:35:10Z

📦 New public release are available for 6.0.0.26032+2040

Update pyrevitlib\pyrevit\revit\selection.py

c196e04

Implemented the creation of a work plane for the current view. Without this, the PickPoint() function does not work. This is relevant for ceiling plans, where a work plane is sometimes not assigned during creation.

jmcouffin requested a review from Copilot January 15, 2026 13:05

Copilot started reviewing on behalf of jmcouffin January 15, 2026 13:06 View session

jmcouffin reviewed Jan 15, 2026

View reviewed changes

pyrevitlib/pyrevit/revit/selection.py Outdated Show resolved Hide resolved

c

75bff42

Some fix.

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Denver-22 added 4 commits January 15, 2026 16:31

Update pick_point() in pyrevitlib\pyrevit\revit\selection.py

fa4f7de

Some corrections based on comments

Update pick_point() in pyrevitlib\pyrevit\revit\selection.py

99b79f1

Fix 'English_USA' language

Merge branch 'pyrevitlabs:develop' into develop

4ffa58a

Update pick_point() in pyrevitlib\pyrevit\revit\selection.py

fea10fa

To avoid potential future naming conflicts between DB and pyrevit.revit.

jmcouffin added the Enhancement Enhancement request [class->Improved #{number}: {title}] label Jan 15, 2026

jmcouffin approved these changes Jan 17, 2026

View reviewed changes

jmcouffin merged commit 4031171 into pyrevitlabs:develop Jan 17, 2026

Uh oh!

Conversation

Denver-22 commented Jan 15, 2026

Uh oh!

devloai bot commented Jan 15, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmcouffin commented Jan 15, 2026

Uh oh!

Denver-22 commented Jan 15, 2026

Uh oh!

jmcouffin commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

Denver-22 commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026