Add translations to toggle text#3012
Conversation
There was a problem hiding this comment.
PR Summary:
This PR completes the localization work from PR #2793 by adding translations for the console toggle option text "Minimize the number of open consoles:" which was previously hardcoded in English. The changes include:
- Updated main XAML file to use
DynamicResourcebinding instead of hardcoded text - Added new translation key
CoreSettings.CloseOtherConsoles.Toggleto all 6 supported language files (English, French, German, Spanish, Russian, Chinese)
Review Summary:
The PR successfully implements proper localization for the toggle button text across all supported languages. All translations are present, correctly positioned, and follow the established naming pattern. The XAML binding is properly implemented. I verified that all language fields contain content in the correct language and that the new translation key is consistently added across all resource dictionary files.
One minor suggestion was made to improve the Chinese translation's word order for better readability, following standard Chinese UI text conventions. Overall, this is a clean, focused PR that completes the internationalization work.
Follow-up suggestions:
- @devloai fix the Chinese translation word order as suggested
...evit.tab/pyRevit.panel/Settings.smartbutton/SettingsWindow.ResourceDictionary.chinese_s.xaml
Outdated
Show resolved
Hide resolved
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26014+2042-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26014+2113-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26017+0925-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26017+0934-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26017+1003-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26017+2108-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26017+2119-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2117-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2124-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2138-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2136-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2141-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1329-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1418-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2037-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2039-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2101-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2136-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2147-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2212-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1043-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1111-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1304-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1323-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1433-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1538-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1543-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1553-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1612-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1624-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1738-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1743-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1829-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1937-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26032+1956-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2005-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2008-wip |
|
📦 New public release are available for 6.0.0.26032+2040 |
|
📦 New public release are available for 6.0.0.26032+2040 |
Add translations to the console toggle option, wich remained in english in my previous PR #2793