Skip to content

Add German, Spanish, and Chinese translations for pyRevit core tools UI#2994

Merged
jmcouffin merged 11 commits intodevelopfrom
settings-localization
Jan 8, 2026
Merged

Add German, Spanish, and Chinese translations for pyRevit core tools UI#2994
jmcouffin merged 11 commits intodevelopfrom
settings-localization

Conversation

@jmcouffin
Copy link
Copy Markdown
Contributor

@jmcouffin jmcouffin commented Jan 8, 2026

  • Added translations for the core tools windows in German (de_de), Spanish (es_es), and Chinese (zh_cn).
  • Updated existing YAML file to include Chinese tooltip descriptions.
  • Enhanced user experience by providing localized settings options for a broader audience.

- Added translations for the settings window in German (de_de), Spanish (es_es), and Chinese (zh_cn).
- Updated existing YAML file to include Chinese tooltip descriptions.
- Enhanced user experience by providing localized settings options for a broader audience.
@jmcouffin jmcouffin added the Localization Issues related to pyRevit localization [subsystem] label Jan 8, 2026
@jmcouffin jmcouffin self-assigned this Jan 8, 2026
@jmcouffin jmcouffin requested a review from Copilot January 8, 2026 21:27
Copy link
Copy Markdown
Contributor

@devloai devloai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary:

This PR adds comprehensive UI translations for the pyRevit Settings window in three new languages:

  • German (de_de): Complete translation of all 387 UI strings
  • Spanish (es_es): Complete translation of all 387 UI strings
  • Chinese (zh_cn): Complete translation of all 386 UI strings
  • bundle.yaml: Updated with Chinese tooltip description

The translations enable German, Spanish, and Chinese-speaking users to access pyRevit settings in their native languages, significantly improving accessibility.

Review Summary:

Reviewed all three new XAML resource dictionary files and the updated bundle.yaml configuration. The translations are comprehensive and structurally sound. All XAML syntax is correct and follows the established pattern from existing translation files (en_us, fr_fr, ru).

Issue identified: All three translation files have copied a pre-existing bug from the English source where UI-UX.FamilySample1 displays "Family 2" instead of "Family 1". This should be corrected to "Familie 1" (German), "Familia 1" (Spanish), and "族 1" (Chinese) to maintain consistent sample numbering. This same bug also exists in the French translation.

The repository guidelines for black formatting and PEP8 are not applicable to XAML translation files.

Follow-up suggestions:

  • @devloai fix the identified family sample label issues
  • @devloai check if the French translation file has the same issue and fix it too

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds localization support for German, Spanish, and Chinese languages to the pyRevit Settings UI. The changes enable users who speak these languages to interact with the pyRevit settings window in their native language, significantly improving accessibility and user experience for a broader international audience.

  • Added three complete XAML resource dictionary files for German (de_de), Spanish (es_es), and Chinese (zh_cn) translations
  • Updated bundle.yaml to include Chinese title and tooltip translations
  • Improved YAML formatting with whitespace cleanup

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
bundle.yaml Added Chinese (zh_cn) title and tooltip translations; cleaned up whitespace formatting
SettingsWindow.ResourceDictionary.zh_cn.xaml Complete Chinese translation resource dictionary with 386 localized UI strings
SettingsWindow.ResourceDictionary.es_es.xaml Complete Spanish translation resource dictionary with 386 localized UI strings
SettingsWindow.ResourceDictionary.de_de.xaml Complete German translation resource dictionary with 386 localized UI strings

- Added French (fr_fr) and Chinese (zh_cn) translations for the Extensions button in the YAML configuration.
- Updated tooltips to include translations for better accessibility and user experience across multiple languages.
@jmcouffin jmcouffin changed the title Add German, Spanish, and Chinese translations for pyRevit settings UI Add German, Spanish, and Chinese translations for pyRevit core tools UI Jan 8, 2026
- Changed language key from 'zh_cn' to 'chinese_s' for consistency in the YAML configuration.
- Updated tooltips and titles to reflect the new language key for better localization support.
…ranslations across various buttons and tooltips

- Updated Russian translations for multiple buttons and tooltips to ensure consistency.
- Added Chinese translations for several buttons and tooltips to improve accessibility for Chinese-speaking users.
- Removed outdated Chinese resource files to streamline localization efforts.
@jmcouffin jmcouffin requested a review from Copilot January 8, 2026 21:48
jmcouffin and others added 2 commits January 8, 2026 22:49
…tings.smartbutton/SettingsWindow.ResourceDictionary.de_de.xaml

Co-authored-by: devloai[bot] <168258904+devloai[bot]@users.noreply.github.com>
…tings.smartbutton/SettingsWindow.ResourceDictionary.es_es.xaml

Co-authored-by: devloai[bot] <168258904+devloai[bot]@users.noreply.github.com>
…tings.smartbutton/SettingsWindow.ResourceDictionary.chinese_s.xaml

Co-authored-by: devloai[bot] <168258904+devloai[bot]@users.noreply.github.com>
@jmcouffin
Copy link
Copy Markdown
Contributor Author

@devloai please review again whole the file and commits

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 4 comments.

Copy link
Copy Markdown
Contributor

@devloai devloai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary:

This PR adds comprehensive multilingual support for pyRevit core tools UI, introducing translations in:

  • German (de_de): Complete translations for About, Settings, and Extensions windows
  • Spanish (es_es): Full UI translations with tooltip enhancements
  • Chinese (chinese_s): New translations across all core UI components

The PR also standardizes language ordering in bundle.yaml files (en_us first) and includes a typo fix in Spanish translations.

Review Summary:

Reviewed all 30 files including new XAML resource dictionaries and updated bundle.yaml files. The translations are comprehensive and well-structured. Found 2 data integrity bugs in Settings.smartbutton/bundle.yaml that need correction: inconsistent Chinese language code usage (both zh_cn and chinese_s defined) and duplicate Spanish tooltip content. These issues affect language selection functionality and UI display correctness.

Follow-up suggestions:

- Corrected Chinese translation for the About button tooltip for clarity.
- Streamlined the Settings button tooltip by removing redundant lines and ensuring consistency in the Chinese translation.
- Updated the title of the Imported button to improve clarity in English.
@jmcouffin jmcouffin merged commit ffc8ed0 into develop Jan 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26008+2214-wip

@jmcouffin jmcouffin deleted the settings-localization branch January 8, 2026 22:35
@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26010+1645-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26010+2127-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26010+2154-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26011+1925-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2138-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2136-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2141-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1329-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1418-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2037-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2039-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2101-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2136-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2147-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2212-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1043-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1111-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1304-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1323-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1433-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1538-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1543-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1553-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1612-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1624-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1738-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1743-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1829-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1937-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+1956-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2005-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2008-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New public release are available for 6.0.0.26032+2040

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2026

📦 New public release are available for 6.0.0.26032+2040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Localization Issues related to pyRevit localization [subsystem]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants