enhancement to language helper#2959
Conversation
- support for only export missing
There was a problem hiding this comment.
PR Summary:
This PR enhances the translation helper scripts in extras/bundle_translations/ by:
- Adding support for importing CSV files with non-UTF-8 encodings using the
chardetlibrary for automatic encoding detection - Introducing an
ONLY_EXPORT_MISSINGconfiguration flag to optionally export only untranslated entries - Improving YAML formatting configuration with round-trip mode and custom formatting settings
Review Summary:
Reviewed the translation helper enhancements focusing on the encoding detection implementation and new export filtering feature. The core logic for both features is sound, but the encoding detection lacks proper error handling which could cause runtime failures. These are standalone utility scripts in the extras/ directory, so dependency management and defensive programming are particularly important since users may run them in varied environments.
Main concerns:
- The
chardetlibrary is not included in the repository's dependencies (Pipfile) and needs proper handling - Missing error handling for encoding detection failures and decoding errors
- One minor documentation gap for the new configuration flag
All issues have actionable fix suggestions provided.
Follow-up suggestions:
@devloai fix the identified issues- Add proper error handling and fallback mechanisms for encoding detection@devloai add chardet to Pipfile- Include chardet as an optional dependency for translation tools
|
📦 New work-in-progress (wip) builds are available for 5.3.1.25347+2146-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.25347+2208-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.25348+1520-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.25354+0912-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26006+2003-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26006+2004-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26007+1719-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26008+2103-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26008+2214-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26010+1645-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26010+2127-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26010+2154-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26011+1925-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26014+1705-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26014+2042-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26014+2113-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26017+0925-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26017+0934-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26017+1003-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26017+2108-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26017+2119-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2117-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2138-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2136-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2141-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1329-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1418-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2037-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2039-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2101-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2136-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2147-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2212-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1043-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1111-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1304-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1323-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1433-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1538-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1543-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1553-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1612-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1624-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1738-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1743-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1829-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1937-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26032+1956-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2005-wip |
|
📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2008-wip |
|
📦 New public release are available for 6.0.0.26032+2040 |
|
📦 New public release are available for 6.0.0.26032+2040 |
Description
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request:
Additional Notes
Include any additional context, screenshots, or considerations for reviewers.
Thank you for contributing to pyRevit! 🎉