New feature window pos by Wurschdhaud · Pull Request #2941 · pyrevitlabs/pyRevit

Wurschdhaud · 2025-11-30T16:52:36Z

Description

This PR introduces new helper functions restore_window_position() and save_window_position() to simplify persistent window positioning across pyRevit sessions. These functions encapsulate the common pattern of storing/restoring window coordinates with screen visibility validation.

Implemented in "measure 3d" for testing.

Question for reviewers: Are there better or more Windows-native solutions for handling window position persistence that I should be aware of? I'm not familiar with alternatives beyond this approach.

Checklist

Before submitting your pull request, ensure the following requirements are met:

Code follows the PEP 8 style guide.
Code has been formatted with Black using the command:

  pipenv run black {source_file_or_directory}

Changes are tested and verified to work as expected.

Related Issues

If applicable, link the issues resolved by this pull request:

Resolves #[issue number]

Additional Notes

Validates saved positions are visible on current screen configuration
Falls back to center screen if saved position is invalid or off-screen
Uses existing script.load_data() / script.store_data() infrastructure

Thank you for contributing to pyRevit! 🎉

devloai · 2025-11-30T16:52:39Z

Unable to perform a code review. You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

Copilot

Pull request overview

This PR introduces reusable helper functions restore_window_position() and save_window_position() to standardize window position persistence across pyRevit tools. The pattern is demonstrated by refactoring the "Measure 3D" tool to use these new utilities instead of inline position management code.

Key changes:

Added restore_window_position() and save_window_position() helper functions in pyrevit/script.py
Refactored Measure 3D tool to use new helper functions, removing ~20 lines of duplicated code
Removed unused System import from Measure tool

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
`pyrevitlib/pyrevit/script.py`	Added two new helper functions for window position persistence with screen visibility validation
`extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Measure.pushbutton/script.py`	Refactored to use new helper functions, removing inline window position management code and unused import

pyrevitlib/pyrevit/script.py

- store width+height - reuse coreutils function

jmcouffin · 2025-12-07T18:54:04Z

Great stuff
In terms of UX, this should be the default behavior.

Would you mind opening an issue about all the tools that could benefit from this @Wurschdhaud ?

github-actions · 2025-12-09T23:22:15Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25343+2308-wip

github-actions · 2025-12-13T18:02:41Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25347+1751-wip

github-actions · 2025-12-13T21:59:45Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25347+2146-wip

github-actions · 2025-12-13T22:21:03Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25347+2208-wip

github-actions · 2025-12-14T15:33:16Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25348+1520-wip

github-actions · 2025-12-20T09:25:56Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25354+0912-wip

github-actions · 2026-01-06T20:15:38Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26006+2003-wip

github-actions · 2026-01-06T20:17:07Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26006+2004-wip

github-actions · 2026-01-07T17:33:13Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26007+1719-wip

github-actions · 2026-01-08T21:19:28Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26008+2103-wip

github-actions · 2026-01-08T22:32:20Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26008+2214-wip

github-actions · 2026-01-10T16:58:16Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26010+1645-wip

github-actions · 2026-01-10T21:40:23Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26010+2127-wip

github-actions · 2026-01-10T22:09:51Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26010+2154-wip

github-actions · 2026-01-11T19:38:25Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26011+1925-wip

github-actions · 2026-01-14T17:18:30Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26014+1705-wip

github-actions · 2026-01-14T20:58:17Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26014+2042-wip

github-actions · 2026-01-22T21:54:00Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2138-wip

github-actions · 2026-01-23T21:50:21Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2136-wip

github-actions · 2026-01-23T22:00:37Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2141-wip

github-actions · 2026-01-25T13:43:26Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1329-wip

github-actions · 2026-01-25T14:30:10Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1418-wip

github-actions · 2026-01-30T20:50:20Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2037-wip

github-actions · 2026-01-30T20:51:11Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2039-wip

github-actions · 2026-01-30T21:15:41Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2101-wip

github-actions · 2026-01-30T21:48:46Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2136-wip

github-actions · 2026-01-30T22:02:00Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2147-wip

github-actions · 2026-01-30T22:23:53Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2212-wip

github-actions · 2026-02-01T10:56:03Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1043-wip

github-actions · 2026-02-01T11:23:52Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1111-wip

github-actions · 2026-02-01T13:16:53Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1304-wip

github-actions · 2026-02-01T13:36:11Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1323-wip

github-actions · 2026-02-01T14:48:37Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1433-wip

github-actions · 2026-02-01T15:50:20Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1538-wip

github-actions · 2026-02-01T15:56:48Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1543-wip

github-actions · 2026-02-01T16:05:37Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1553-wip

github-actions · 2026-02-01T16:24:45Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1612-wip

github-actions · 2026-02-01T16:38:59Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1624-wip

github-actions · 2026-02-01T17:50:38Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1738-wip

github-actions · 2026-02-01T17:56:35Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1743-wip

github-actions · 2026-02-01T18:45:18Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1829-wip

github-actions · 2026-02-01T19:50:47Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1937-wip

github-actions · 2026-02-01T20:08:31Z

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+1956-wip

github-actions · 2026-02-01T20:17:09Z

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2005-wip

github-actions · 2026-02-01T20:20:49Z

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2008-wip

github-actions · 2026-02-01T20:24:58Z

📦 New public release are available for 6.0.0.26032+2040

github-actions · 2026-02-01T20:35:29Z

📦 New public release are available for 6.0.0.26032+2040

Wurschdhaud added 2 commits November 30, 2025 17:49

add store and restore window pos functions

0adabeb

implement new functions available in lib

9d43e7c

jmcouffin requested a review from Copilot November 30, 2025 16:58

Copilot started reviewing on behalf of jmcouffin November 30, 2025 16:59 View session

Copilot finished reviewing on behalf of jmcouffin November 30, 2025 17:01

Copilot AI reviewed Nov 30, 2025

View reviewed changes

pyrevitlib/pyrevit/script.py Show resolved Hide resolved

pyrevitlib/pyrevit/script.py Outdated Show resolved Hide resolved

pyrevitlib/pyrevit/script.py Outdated Show resolved Hide resolved

pyrevitlib/pyrevit/script.py Outdated Show resolved Hide resolved

- improved docstring

4747b8c

- store width+height - reuse coreutils function

jmcouffin added the Enhancement Enhancement request [class->Improved #{number}: {title}] label Dec 7, 2025

jmcouffin merged commit 03bb5b4 into pyrevitlabs:develop Dec 7, 2025

Wurschdhaud deleted the new-feature-window-pos branch December 7, 2025 19:08

Wurschdhaud mentioned this pull request Jan 11, 2026

Enhance ColorSplasher functionality and localization #3005

Merged

3 tasks

Uh oh!

Conversation

Wurschdhaud commented Nov 30, 2025

Description

Checklist

Related Issues

Additional Notes

Uh oh!

devloai bot commented Nov 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmcouffin commented Dec 7, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 14, 2025

Uh oh!

github-actions bot commented Dec 20, 2025

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

github-actions bot commented Jan 11, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026