chore: tools Minor fixes by Wurschdhaud · Pull Request #2915 · pyrevitlabs/pyRevit

Wurschdhaud · 2025-11-08T10:48:46Z

Description

The type of minor annoyances you only notice after a few weeks time:

lib commands used when possible
accidentally used global variable
add formatting and slope to measure 3D tool

Checklist

Before submitting your pull request, ensure the following requirements are met:

Code follows the PEP 8 style guide.
Code has been formatted with black
Changes are tested and verified to work as expected.

- add toast to alert user - formatting of xyz to make it more readable

devloai

PR Summary:

This PR addresses minor quality-of-life improvements:

Replaces manual API calls with pyRevit library helpers (revit.query.get_elements_by_class(), revit.get_selection().set_to())
Fixes global variable bugs in Orient Section Box/View scripts (using function parameter view instead of global curview)
Adds slope calculation and improved formatting to the Measure 3D tool
Replaces pickle serialization with pyRevit's script.store_data/load_data API
Improves error handling (using logger.exception())

Review Summary:

All changes are well-implemented and appropriate for IronPython 2.7.12. The global variable fixes in the Orient scripts are important bug corrections that prevent stale reference issues. The library function usage follows pyRevit best practices. Code adheres to Black formatting and PEP8 naming conventions. No critical issues identified.

Follow-up suggestions:

No follow-up actions needed - the PR is ready to merge as-is.

jmcouffin · 2025-11-08T11:08:39Z

Great stuff,
If you don't mind, next time, try to break down a PR like this one in two: one for changing the usage of pyrevit lib specific method, another to add slope to 3d measurements tools

github-actions · 2025-11-08T11:24:26Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25312+1112-wip

github-actions · 2025-11-13T13:08:08Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25317+1256-wip

github-actions · 2025-11-17T20:24:42Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25321+2012-wip

github-actions · 2025-11-21T22:07:08Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25325+2154-wip

github-actions · 2025-11-22T10:51:55Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25326+1040-wip

github-actions · 2025-11-22T21:02:43Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25326+2050-wip

github-actions · 2025-11-26T00:39:23Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25330+0026-wip

github-actions · 2025-11-26T21:50:54Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25330+2139-wip

github-actions · 2025-11-27T09:04:42Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25331+0850-wip

github-actions · 2025-11-28T23:06:55Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25332+2254-wip

github-actions · 2025-11-30T16:59:28Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25334+1646-wip

github-actions · 2025-11-30T17:16:34Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25334+1705-wip

github-actions · 2025-12-02T12:43:59Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25336+1232-wip

github-actions · 2025-12-09T23:22:28Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25343+2308-wip

github-actions · 2025-12-13T18:02:53Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25347+1751-wip

github-actions · 2025-12-13T22:00:00Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25347+2146-wip

github-actions · 2025-12-13T22:21:20Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25347+2208-wip

github-actions · 2025-12-14T15:33:29Z

📦 New work-in-progress (wip) builds are available for 5.3.1.25348+1520-wip

github-actions · 2026-01-14T17:18:49Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26014+1705-wip

github-actions · 2026-01-14T20:58:31Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26014+2042-wip

github-actions · 2026-01-14T21:27:36Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26014+2113-wip

github-actions · 2026-01-17T09:38:54Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26017+0925-wip

github-actions · 2026-01-17T09:48:20Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26017+0934-wip

github-actions · 2026-01-17T10:16:06Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26017+1003-wip

github-actions · 2026-01-17T21:21:28Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26017+2108-wip

github-actions · 2026-01-17T21:32:49Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26017+2119-wip

github-actions · 2026-01-22T21:35:01Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2117-wip

github-actions · 2026-01-22T21:42:57Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2124-wip

github-actions · 2026-01-22T21:54:22Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26022+2138-wip

github-actions · 2026-01-23T21:50:34Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2136-wip

github-actions · 2026-01-23T22:00:53Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26023+2141-wip

github-actions · 2026-01-25T13:43:42Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1329-wip

github-actions · 2026-01-25T14:30:24Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26025+1418-wip

github-actions · 2026-01-30T20:50:40Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2037-wip

github-actions · 2026-01-30T20:51:31Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2039-wip

github-actions · 2026-01-30T21:15:55Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2101-wip

github-actions · 2026-01-30T21:49:02Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2136-wip

github-actions · 2026-01-30T22:02:18Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2147-wip

github-actions · 2026-01-30T22:24:08Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26030+2212-wip

github-actions · 2026-02-01T10:56:15Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1043-wip

github-actions · 2026-02-01T11:24:06Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1111-wip

github-actions · 2026-02-01T13:17:06Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1304-wip

github-actions · 2026-02-01T13:36:24Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1323-wip

github-actions · 2026-02-01T14:48:52Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1433-wip

github-actions · 2026-02-01T15:50:34Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1538-wip

github-actions · 2026-02-01T15:57:00Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1543-wip

github-actions · 2026-02-01T16:05:50Z

📦 New work-in-progress (wip) builds are available for 5.3.1.26032+1553-wip

github-actions · 2026-02-01T20:17:26Z

📦 New work-in-progress (wip) builds are available for 6.0.0.26032+2005-wip

Wurschdhaud added 4 commits November 8, 2025 11:41

- add slope

e1cba79

- add toast to alert user - formatting of xyz to make it more readable

use var in function instead of global one

74865be

use lib commands

ebc33cc

add missin slope unit symbol label message

20cab30

devloai bot reviewed Nov 8, 2025

View reviewed changes

jmcouffin changed the title ~~Minor fixes~~ chore: tools Minor fixes Nov 8, 2025

jmcouffin added the Tools Issues related to pyRevit commands [subsystem] label Nov 8, 2025

jmcouffin approved these changes Nov 8, 2025

View reviewed changes

jmcouffin merged commit 6b96175 into pyrevitlabs:develop Nov 8, 2025

Wurschdhaud deleted the minor-fixes branch November 8, 2025 11:12

Copilot AI mentioned this pull request Nov 11, 2025

Review: PR #2915 - Minor tools fixes (bug fixes, security, slope feature) #2920

Closed

3 tasks

Uh oh!

Conversation

Wurschdhaud commented Nov 8, 2025 • edited by jmcouffin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

devloai bot left a comment

Choose a reason for hiding this comment

PR Summary:

Review Summary:

Follow-up suggestions:

Uh oh!

jmcouffin commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 17, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 22, 2025

Uh oh!

github-actions bot commented Nov 22, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 27, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 14, 2025

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

Uh oh!

github-actions bot commented Jan 25, 2026

Wurschdhaud commented Nov 8, 2025 •

edited by jmcouffin

Loading