add shift-click to bypass issued check#2897
Conversation
There was a problem hiding this comment.
PR Summary:
This PR adds a Shift+Click bypass feature to the "Set Revision On Sheets" tool, allowing users to include issued revisions in the selection list. The implementation:
- Uses pyRevit's built-in
EXEC_PARAMS.config_modemechanism (triggered by Shift+Click) - Updates the filter function to conditionally bypass the issued revision check
- Documents the feature in tooltips across all supported languages (EN, DE, FR, RU)
Review Summary:
The implementation is clean and follows established pyRevit patterns. The code correctly leverages the framework's config_mode property to provide an intuitive Shift+Click bypass mechanism. No logic bugs, security issues, or performance concerns identified. The feature is well-documented in the user-facing tooltips.
Follow-up suggestions:
None needed - the implementation is production-ready as-is.
…rity and formatting
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+1644-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+1935-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+2011-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+2045-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.0.25307+2237-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.0.25308+0721-wip |
|
📦 New public release are available for 5.3.0.25307+2146 |
Description
Enhancement for Set Revisions on Sheets
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}