Fix "Sum Total" not addressing unit conversion for others than length/area/volume#2875
Merged
jmcouffin merged 1 commit intopyrevitlabs:developfrom Oct 20, 2025
Merged
Conversation
…hardcoded length/area/volume - removes hardcoded entirely by reusing format_value - formatted using black
Contributor
|
Unable to perform a code review. You have run out of credits 😔 |
jmcouffin
approved these changes
Oct 20, 2025
Contributor
jmcouffin
left a comment
There was a problem hiding this comment.
Tested in 2024
All Good,
Good one, Thank you @Wurschdhaud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request:
Additional Notes
Include any additional context, screenshots, or considerations for reviewers.
Thank you for contributing to pyRevit! 🎉