enhancenment for select all objects passing filter#2804
Conversation
There was a problem hiding this comment.
PR Summary:
This PR enhances the "Select All Objects Passing Filter" tool with three new configuration options:
• Exclude Nested - Skip nested family instances using SuperComponent check
• Scope Control - Choose between current view only or entire project
• Reverse Selection - Select elements that fail the filter instead of passing it
Review Summary:
Reviewed the enhancement focusing on logic correctness and performance patterns. Found 2 critical issues that need attention: a logic bug with default configuration values and a performance issue with element filtering approach. The review utilized pyRevit's efficient query patterns knowledge and IronPython-specific requirements to ensure compatibility and performance in large projects.
Follow-up suggestions:
• @devloai fix the identified configuration logic and performance issues
• @devloai add progress bar support for large project operations
...on.panel/select.stack/Select.pulldown/Select All Objects Passing Filter.pushbutton/config.py
Outdated
Show resolved
Hide resolved
...on.panel/select.stack/Select.pulldown/Select All Objects Passing Filter.pushbutton/script.py
Outdated
Show resolved
Hide resolved
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25256+0727-wip |
|
@Wurschdhaud can you contact me in dm on the forum or by email (my username on github + @gmail.com) I want to ask you something or on telegram |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25258+1448-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25265+1047-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25266+0803-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25268+1757-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1336-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1431-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1436-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1822-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25271+1719-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2003-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2012-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2017-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2149-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25274+1734-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1425-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1427-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25279+2157-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25280+0218-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1054-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1057-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25282+1656-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25283+0140-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25286+1022-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25287+0905-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25287+1000-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25288+0613-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25293+0755-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25293+0828-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25293+1113-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25293+1234-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25295+0707-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0824-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0837-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0923-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25300+1037-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25301+1412-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25301+1521-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25302+0921-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25302+0949-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25302+1503-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+1644-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+1935-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+2011-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+2045-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.0.25307+2237-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.0.25308+0721-wip |
|
📦 New public release are available for 5.3.0.25307+2146 |
Description
added config for:
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request:
Additional Notes
tooltips updated via AI, no native speaker
Thank you for contributing to pyRevit! 🎉