Refactor Section Box Tool to Support Configurable Toggle for Visibility or Active State by Wurschdhaud · Pull Request #2797 · pyrevitlabs/pyRevit

Wurschdhaud · 2025-09-06T08:34:54Z

Description

This PR refactors the existing Section Box toggle tool to support two distinct operational modes based on configuration:

Visibility mode: Toggles whether the section box is visible in the current 3D view.
Active state mode: Toggles whether the section box is active (enabled) in the current 3D view, with saved/restored bounding box geometry per view.

The tool now respects this configuration to perform either action (not both), depending on user preference.
In active mode, the section box bounding box is serialized safely using primitive data (due to .NET serialization limits in IronPython) and stored per-view for accurate restoration.

Tooltips have been updated in all supported languages (EN, DE, FR, RU) to reflect this new behavior and configuration-dependence. →generated by AI

Checklist

Before submitting your pull request, ensure the following requirements are met:

Code follows the PEP 8 style guide.
Code has been formatted with Black using the command:
```
pipenv run black {source_file_or_directory}
```
Changes are tested and verified to work as expected. → Revit 2024

Related Issues

If applicable, link the issues resolved by this pull request:

Resolves #[issue number]

Additional Notes

Serialization handles BoundingBoxXYZ safely by extracting min/max points and transform components, avoiding direct .NET object pickling (which fails under IronPython).
Each 3D view has its own section box state saved independently.

Thank you for contributing to pyRevit! 🎉

devloai

PR Summary:

This PR refactors the Section Box toggle tool to support configurable operation modes: visibility toggle vs active state toggle. The tool now saves/restores section box geometry per view in active mode, with proper serialization handling for .NET types in IronPython. Updated tooltips across multiple languages reflect the new configurable behavior.

Review Summary:

Found several critical bugs that need fixing before merge: consistent typos in configuration variable names that break functionality, logic issues allowing invalid configuration states, missing validation for mutually exclusive modes, resource management problems with file handles, and incomplete toggle operation in active mode. Review applied knowledge of pyRevit configuration patterns, IronPython resource management requirements, and tool validation standards.

Follow-up suggestions:

@devloai fix the identified issues
@devloai add validation to prevent invalid configuration states

...evitTools.extension/pyRevit.tab/Toggles.panel/toggles2.stack/SectionBox.pushbutton/config.py

...evitTools.extension/pyRevit.tab/Toggles.panel/toggles2.stack/SectionBox.pushbutton/script.py

jmcouffin

Tested, works according to plan 2024-2026

jmcouffin · 2025-09-08T07:55:28Z

Thanks @Wurschdhaud

github-actions · 2025-09-08T08:09:12Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0758-wip

github-actions · 2025-09-08T08:16:36Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0805-wip

github-actions · 2025-09-08T08:38:43Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0824-wip

github-actions · 2025-09-09T17:11:28Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25252+1659-wip

github-actions · 2025-09-12T06:55:28Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25255+0644-wip

github-actions · 2025-09-12T09:22:18Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25255+0911-wip

github-actions · 2025-09-13T07:37:56Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25256+0727-wip

github-actions · 2025-09-15T15:01:01Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25258+1448-wip

github-actions · 2025-09-22T10:57:57Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25265+1047-wip

github-actions · 2025-09-23T08:16:07Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25266+0803-wip

github-actions · 2025-09-25T18:08:48Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25268+1757-wip

github-actions · 2025-09-26T13:49:25Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1336-wip

github-actions · 2025-09-26T14:45:19Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1431-wip

github-actions · 2025-09-26T14:48:39Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1436-wip

github-actions · 2025-09-26T18:34:59Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1822-wip

github-actions · 2025-09-28T17:31:34Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25271+1719-wip

github-actions · 2025-09-29T20:18:20Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2003-wip

github-actions · 2025-09-29T20:23:31Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2012-wip

github-actions · 2025-10-07T02:30:42Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+0218-wip

github-actions · 2025-10-07T11:08:15Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1054-wip

github-actions · 2025-10-07T11:10:18Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1057-wip

github-actions · 2025-10-09T17:11:15Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25282+1656-wip

github-actions · 2025-10-10T01:54:20Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25283+0140-wip

github-actions · 2025-10-13T10:35:12Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25286+1022-wip

github-actions · 2025-10-14T09:18:05Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25287+0905-wip

github-actions · 2025-10-14T10:15:09Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25287+1000-wip

github-actions · 2025-10-15T06:28:23Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25288+0613-wip

github-actions · 2025-10-20T08:09:19Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+0755-wip

github-actions · 2025-10-20T08:40:44Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+0828-wip

github-actions · 2025-10-20T11:26:28Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+1113-wip

github-actions · 2025-10-20T12:47:47Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+1234-wip

github-actions · 2025-10-22T07:19:10Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25295+0707-wip

github-actions · 2025-10-23T08:38:30Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0824-wip

github-actions · 2025-10-23T08:49:50Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0837-wip

github-actions · 2025-10-23T09:36:50Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0923-wip

github-actions · 2025-10-27T10:53:14Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25300+1037-wip

github-actions · 2025-10-28T14:24:36Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25301+1412-wip

github-actions · 2025-10-28T15:33:09Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25301+1521-wip

github-actions · 2025-10-29T09:34:38Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25302+0921-wip

github-actions · 2025-10-29T10:02:39Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25302+0949-wip

github-actions · 2025-10-29T15:16:08Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25302+1503-wip

github-actions · 2025-11-03T17:02:20Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25307+1644-wip

github-actions · 2025-11-03T19:48:19Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25307+1935-wip

github-actions · 2025-11-03T20:24:45Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25307+2011-wip

github-actions · 2025-11-03T21:00:22Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25307+2045-wip

github-actions · 2025-11-03T22:50:31Z

📦 New work-in-progress (wip) builds are available for 5.3.0.25307+2237-wip

github-actions · 2025-11-04T07:35:17Z

📦 New work-in-progress (wip) builds are available for 5.3.0.25308+0721-wip

github-actions · 2025-11-04T07:58:25Z

📦 New public release are available for 5.3.0.25307+2146

initial commit

fe878b4

devloai bot reviewed Sep 6, 2025

View reviewed changes

Wurschdhaud added 4 commits September 6, 2025 10:47

fix sb_visibility typo

ab957dc

add hint for user that neither are enabled

9e029cc

added context manager

4fc8dc9

simplified config by using ask_for_one_item

5008fda

jmcouffin approved these changes Sep 8, 2025

View reviewed changes

jmcouffin merged commit 54933e4 into pyrevitlabs:develop Sep 8, 2025

jmcouffin added Tools Issues related to pyRevit commands [subsystem] Enhancement Enhancement request [class->Improved #{number}: {title}] labels Sep 8, 2025

Wurschdhaud deleted the enhancement-for-section-box-toggle branch September 8, 2025 08:42

Uh oh!

Conversation

Wurschdhaud commented Sep 6, 2025

Description

Checklist

Related Issues

Additional Notes

Uh oh!

devloai bot left a comment

Choose a reason for hiding this comment

PR Summary:

Review Summary:

Follow-up suggestions:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmcouffin left a comment

Choose a reason for hiding this comment

Uh oh!

jmcouffin commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

github-actions bot commented Sep 13, 2025

Uh oh!

github-actions bot commented Sep 15, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 28, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 20, 2025