added support for linked files - same as orient section box#2782
added support for linked files - same as orient section box#2782jmcouffin merged 1 commit intopyrevitlabs:developfrom
Conversation
There was a problem hiding this comment.
PR Summary:
• Extends "Orient View To Face" tool to support linked files using PointOnElement selection
• Applies same pattern successfully implemented in PR #2781 for section box orientation
• Implements coordinate transformation between linked and world coordinate systems
• Maintains backward compatibility with existing non-linked element functionality
Review Summary:
The PR correctly implements linked file support using the established PointOnElement selection pattern. However, it's missing critical defensive null checks for linked document operations that could cause runtime exceptions. The knowledge base defensive patterns emphasize that both GetLinkDocument() and LinkedElementId can return null, requiring explicit validation before use.
Follow-up suggestions:
@devloai fix the identified defensive null check issues
...ools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Orient View To Face.pushbutton/script.py
Show resolved
Hide resolved
...ools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Orient View To Face.pushbutton/script.py
Show resolved
Hide resolved
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25245+0639-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25245+0642-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25245+1846-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25246+0855-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25248+0948-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0758-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0805-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0824-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25252+1659-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25255+0644-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25255+0911-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25256+0727-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25258+1448-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25265+1047-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25266+0803-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25268+1757-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1336-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1431-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1436-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1822-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25271+1719-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2003-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2012-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1427-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25279+2157-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25280+0218-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1054-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1057-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25282+1656-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25283+0140-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25286+1022-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25287+0905-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25287+1000-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25288+0613-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25293+0755-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25293+0828-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25293+1113-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25293+1234-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25295+0707-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0824-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0837-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0923-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25300+1037-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25301+1412-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25301+1521-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25302+0921-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25302+0949-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25302+1503-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+1644-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+1935-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+2011-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+2045-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.0.25307+2237-wip |
Name of your PR
Description
same as in #2781 only now for view orientation
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}