Issues/#2317 - Add New "Mass Pin/Unpin" Tool with Category Selection#2772
Merged
jmcouffin merged 4 commits intopyrevitlabs:developfrom Aug 25, 2025
Merged
Issues/#2317 - Add New "Mass Pin/Unpin" Tool with Category Selection#2772jmcouffin merged 4 commits intopyrevitlabs:developfrom
jmcouffin merged 4 commits intopyrevitlabs:developfrom
Conversation
Contributor
There was a problem hiding this comment.
PR Summary:
- Adds new "Mass Pin/Unpin References" tool for bulk pinning/unpinning elements
- Supports multiple categories: Grids, Levels, Revit Links, Section Boxes, DWG imports, Project/Survey Points
- Uses category selection dialog with shift-click toggle between pin/unpin modes
- Implements proper transaction handling and multi-language support
Review Summary:
Reviewed the implementation against pyRevit coding standards and Revit API patterns. The core functionality and architecture follow established pyRevit conventions for category selection and transaction management. Found one critical logic issue with DWG import filtering that needs correction to match the advertised functionality.
Follow-up suggestions:
@devloai fix the identified DWG filtering issue
.../pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Mass Pin References.pushbutton/script.py
Show resolved
Hide resolved
jmcouffin
approved these changes
Aug 25, 2025
Contributor
|
I like the fact you used the shift click to toggle the functionality, not intuitive for people new to pyRevit, but well, everyone has to learn anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new tool that allows users to pin or unpin multiple elements across a variety of categories from a single interface.
The script opens a selection dialog where users can choose which element categories to apply the action to. Supported categories include:
Once selected, the tool will pin or unpin only those elements, based on the current configuration mode (shift-click).
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request:
Thank you for contributing to pyRevit! 🎉