Add .NET 8 Runtime Check to Installer Scripts by jmcouffin · Pull Request #2762 · pyrevitlabs/pyRevit

jmcouffin · 2025-08-19T19:48:54Z

Description

Implemented a check for the .NET 8 Runtime in the installation scripts for pyRevit, pyRevit CLI, and pyRevit Admin. If the required runtime is not found, users are prompted to download it from the official Microsoft site. This ensures that the application has the necessary dependencies before proceeding with the installation.
Fixes [Bug]: Installer does not check for .NET "core" runtime #2730

Changes are tested and verified to work as expected.

Related Issues

If applicable, link the issues resolved by this pull request:

Resolves [Bug]: Installer does not check for .NET "core" runtime #2730

Additional Notes

I could also have used the https://github.com/DomGries/InnoDependencyInstaller
but I did not want to had more dependencies to the tech stack

Thank you for contributing to pyRevit! 🎉

Implemented a check for the .NET 8 Runtime in the installation scripts for pyRevit, pyRevit CLI, and pyRevit Admin. If the required runtime is not found, users are prompted to download it from the official Microsoft site. This ensures that the application has the necessary dependencies before proceeding with the installation. Fixes [Bug]: Installer does not check for .NET "core" runtime #2730

Copilot

Pull Request Overview

Adds .NET 8 Runtime detection to all pyRevit installer scripts to ensure required dependencies are available before installation. The implementation checks for the Windows Desktop App runtime in both x64 and x86 program files locations and prompts users to download it from Microsoft if not found.

Added runtime detection logic that checks for .NET 8 or higher versions in standard installation paths
Implemented user prompting with option to open Microsoft download page when runtime is missing
Integrated the check into the installer initialization process across all four installer variants

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
release/pyrevit.iss	Added .NET 8 runtime check to main pyRevit installer
release/pyrevit-cli.iss	Added .NET 8 runtime check to CLI installer
release/pyrevit-cli-admin.iss	Added .NET 8 runtime check to CLI admin installer
release/pyrevit-admin.iss	Added .NET 8 runtime check to admin installer

release/pyrevit.iss

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

devloai

PR Summary:

Adds .NET 8 Desktop Runtime dependency checks to all four pyRevit installer scripts (.iss files)
Checks both x64 and x86 program files directories for Microsoft.WindowsDesktop.App runtime
Prompts users to download .NET 8 runtime from Microsoft if not found, then aborts installation
Addresses issue #2730 where users couldn't run pyRevit commands due to missing .NET runtime

Review Summary:

This is a solid fix for a critical installation issue. The implementation correctly targets the Microsoft.WindowsDesktop.App runtime which matches the pyrevit.runtimeconfig.json requirements for .NET 8.0. The approach of checking both x64 and x86 paths is appropriate for Windows environments. Found one logic bug in the version parsing that should be addressed to handle edge cases with preview/RC versions.

Follow-up suggestions:

@devloai fix the identified version parsing issue to handle non-numeric version suffixes
@devloai consider testing the installer with various .NET version scenarios (preview, RC, multiple versions)

release/pyrevit.iss

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Enhanced the installer scripts for pyRevit, pyRevit CLI, and pyRevit Admin by introducing a function to extract the major version from the .NET runtime directory names. This allows for a more robust check against the required .NET 8 Runtime version. If the required version is not found, users are prompted to download it from Microsoft, ensuring necessary dependencies are met before installation proceeds.

…om/pyrevitlabs/pyRevit into fix/dotnet-depency-check-installer

Updated the version parsing logic in pyRevit, pyRevit CLI, and pyRevit Admin installer scripts to include comprehensive validation for the major version string. Added checks for valid digit format, reasonable version range (1-99), and improved error logging for better debugging. This ensures that invalid version formats are properly handled, enhancing the robustness of the installation process.

sanzoghenzo · 2025-08-19T20:07:14Z

I ask you the favour of adding me as reviewer only after you run over the AI reviews, so that I don't need to re-check the code each time you push something 😉

Can I start the review now?

sanzoghenzo

Did you see this project? It not only checks for the dependencies, but it also installs it automatically!

It also uses the registry and dotnet --list-runtimes as a more robust way to check for the installed runtimes (user/installers may change the installation path).

You can copy the CodeDependencies.iss file over (and maybe remove the checks we don't need), and follow ExampleSetup.iss to adapt our scripts, Namely:

add #include "CodeDependencies.iss" at the beginning of the file
add ArchitecturesInstallIn64BitMode=x64 in [Setup]

Add the following (not sure if we need both):

[Code]
function InitializeSetup: Boolean;
begin
  Dependency_AddDotNet80;
  Dependency_AddDotNet80Desktop;
  Result := True;
end;

jmcouffin · 2025-08-20T09:46:12Z

I ask you the favour of adding me as reviewer only after you run over the AI reviews, so that I don't need to re-check the code each time you push something 😉

Can I start the review now?

Yes, my bad

Updated the pyRevit, pyRevit CLI, and pyRevit Admin installer scripts to include the "CodeDependencies.iss" file. This change ensures that the necessary dependencies for .NET 8 are properly managed during the installation process, enhancing the overall robustness and reliability of the installation. Additionally, the architectures installation mode has been reinstated to x64 for consistency across scripts.

jmcouffin · 2025-08-20T10:44:25Z

Did you see this project? It not only checks for the dependencies, but it also installs it automatically!

Yes, I noticed the thing, but did not take the time to analyze the complexity of implementation.
Now I have, and yes, that simple.

It also uses the registry and dotnet --list-runtimes as a more robust way to check for the installed runtimes (user/installers may change the installation path).

You can copy the CodeDependencies.iss file over (and maybe remove the checks we don't need), and follow ExampleSetup.iss to adapt our scripts, Namely:

add #include "CodeDependencies.iss" at the beginning of the file

add ArchitecturesInstallIn64BitMode=x64 in [Setup]

Add the following (not sure if we need both):

both are required (at least in the test I have done)

[Code]
function InitializeSetup: Boolean;
begin
  Dependency_AddDotNet80;
  Dependency_AddDotNet80Desktop;
  Result := True;
end;

The testing was a bit more involved, but it works as advertised.

Note to self:
The installer _signed installer for the CLI installs the CLI in an admin location like the admin_signed one.
I guess this has to do with the fact that the CLI requires to edit some addins manifest in admin Revit location.

sanzoghenzo

Nice!
Just one thing: please remove the commented lines of code (//Dependency_AddDotNet...)

(In the future, we could add a script to download the updated version of the CodeDependencies.iss file...)

sanzoghenzo · 2025-08-20T11:13:59Z

The installer _signed installer for the CLI installs the CLI in an admin location like the admin_signed one.
I guess this has to do with the fact that the CLI requires to edit some addins manifest in admin Revit location.

I believe that's because the intended usage of the CLI is for administrative tasks, so Ehsan didn’t create an installer for regular users.

jmcouffin · 2025-08-20T11:19:11Z

(In the future, we could add a script to download the updated version of the CodeDependencies.iss file...)

indeed

jmcouffin · 2025-08-20T11:19:54Z

I believe that's because the intended usage of the CLI is for administrative tasks, so Ehsan didn’t create an installer for regular users.

We should remove the pyrevit-cli.iss then, it would help clarify.

Updated the pyRevit, pyRevit CLI, and pyRevit Admin installer scripts by removing commented-out lines for .NET 8 and 9 dependencies. This cleanup enhances the clarity and maintainability of the scripts, ensuring only relevant dependencies are included.

github-actions · 2025-08-20T11:39:38Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25232+1126-wip

github-actions · 2025-08-20T14:03:35Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25232+1352-wip

github-actions · 2025-08-21T06:49:54Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25233+0639-wip

github-actions · 2025-08-21T14:45:03Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25233+1431-wip

github-actions · 2025-08-21T14:48:41Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25233+1438-wip

github-actions · 2025-09-26T14:45:38Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1431-wip

github-actions · 2025-09-26T14:48:59Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1436-wip

github-actions · 2025-09-26T18:35:21Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1822-wip

github-actions · 2025-09-28T17:31:49Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25271+1719-wip

github-actions · 2025-09-29T20:18:39Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2003-wip

github-actions · 2025-09-29T20:23:52Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2012-wip

github-actions · 2025-09-29T20:29:03Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2017-wip

github-actions · 2025-09-29T22:02:17Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2149-wip

github-actions · 2025-10-01T17:49:21Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25274+1734-wip

github-actions · 2025-10-04T14:38:05Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1425-wip

github-actions · 2025-10-04T14:40:47Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1427-wip

github-actions · 2025-10-06T22:12:20Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25279+2157-wip

github-actions · 2025-10-07T02:30:58Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+0218-wip

github-actions · 2025-10-07T11:08:35Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1054-wip

github-actions · 2025-10-07T11:10:39Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1057-wip

github-actions · 2025-10-09T17:11:34Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25282+1656-wip

github-actions · 2025-10-10T01:54:36Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25283+0140-wip

github-actions · 2025-10-13T10:35:29Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25286+1022-wip

github-actions · 2025-10-14T09:18:26Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25287+0905-wip

github-actions · 2025-10-14T10:15:30Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25287+1000-wip

github-actions · 2025-10-15T06:28:43Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25288+0613-wip

github-actions · 2025-10-20T08:09:39Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+0755-wip

github-actions · 2025-10-20T08:41:01Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+0828-wip

github-actions · 2025-10-20T11:26:45Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+1113-wip

github-actions · 2025-10-20T12:48:08Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+1234-wip

github-actions · 2025-10-22T07:19:27Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25295+0707-wip

github-actions · 2025-10-23T08:38:52Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0824-wip

github-actions · 2025-10-23T08:50:08Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0837-wip

github-actions · 2025-10-23T09:37:08Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25296+0923-wip

github-actions · 2025-10-29T10:03:00Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25302+0949-wip

jmcouffin requested review from Copilot and sanzoghenzo August 19, 2025 19:49

Copilot AI reviewed Aug 19, 2025

View reviewed changes

release/pyrevit.iss Outdated Show resolved Hide resolved

release/pyrevit.iss Outdated Show resolved Hide resolved

Update release/pyrevit.iss

2df1d37

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

devloai bot reviewed Aug 19, 2025

View reviewed changes

release/pyrevit.iss Outdated Show resolved Hide resolved

jmcouffin and others added 4 commits August 19, 2025 21:52

Update release/pyrevit.iss

0727610

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'fix/dotnet-depency-check-installer' of https://github.c…

024be26

…om/pyrevitlabs/pyRevit into fix/dotnet-depency-check-installer

sanzoghenzo reviewed Aug 19, 2025

View reviewed changes

jmcouffin requested a review from sanzoghenzo August 20, 2025 10:44

sanzoghenzo requested changes Aug 20, 2025

View reviewed changes

jmcouffin merged commit 029088e into develop Aug 20, 2025

jmcouffin added Installer Issues related to the pyRevit installer [subsystem] dependencies Pull requests that update a dependency file labels Aug 20, 2025

sanzoghenzo deleted the fix/dotnet-depency-check-installer branch August 20, 2025 14:20

Uh oh!

Conversation

jmcouffin commented Aug 19, 2025

Description

Related Issues

Additional Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

devloai bot left a comment

Choose a reason for hiding this comment

PR Summary:

Review Summary:

Follow-up suggestions:

Uh oh!

Uh oh!

sanzoghenzo commented Aug 19, 2025

Uh oh!

sanzoghenzo left a comment

Choose a reason for hiding this comment

Uh oh!

jmcouffin commented Aug 20, 2025

Uh oh!

jmcouffin commented Aug 20, 2025

Uh oh!

sanzoghenzo left a comment

Choose a reason for hiding this comment

Uh oh!

sanzoghenzo commented Aug 20, 2025

Uh oh!

jmcouffin commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmcouffin commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 28, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 4, 2025

Uh oh!

github-actions bot commented Oct 4, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

jmcouffin commented Aug 20, 2025 •

edited

Loading