Copy Sheets to Open Documents: add “Preserve detail numbers” option (default ON), safer param handling, and richer logs by czwangxtt · Pull Request #2754 · pyrevitlabs/pyRevit

czwangxtt · 2025-08-11T18:13:01Z

Copy Sheets to Open Documents: add “Preserve detail numbers” option (default ON), safer param handling, and richer logs

Description

Extends PR #2704 by making preservation of viewport Detail Number optional. Default is ON to match current behavior. Adds try/except guards to avoid script failure when the parameter is missing, and improves logging for transparency.

Changes

Added checkbox: Preserve Detail Numbers (default ON).
Wrapped parameter read/write in try/except to prevent transaction rollback.
More detailed logs: per-viewport outcome (preserved, renumbered, skipped).

Why

Some workflows require fresh numbering instead of preserving originals.
Prevents crashes in models where the parameter isn’t available.
Clearer feedback during batch copy.

Checklist

Before submitting your pull request, ensure the following requirements are met:

Code follows the PEP 8 style guide.
Code has been formatted with Black using the command:
```
pipenv run black {source_file_or_directory}
```
Changes are tested and verified to work as expected.

Related Issues

Enhanced PR ##2704

Additional Notes

Add preserve detail number as an option. Make the script more robust. Add more details to the log.

devloai

PR Summary:

This PR adds a "Preserve Detail Numbers" option (default ON) to the Copy Sheets to Open Documents tool, extending PR #2704. Key changes include:
• New checkbox option for preserving viewport detail numbers
• Enhanced error handling with try/except blocks around parameter operations
• Improved logging with per-viewport outcome messages
• Maintains backward compatibility with default behavior

Review Summary:

The PR successfully implements the requested feature with good intentions for safer parameter handling. However, the parameter access logic contains potential null reference vulnerabilities that could cause runtime failures. The review focused on defensive programming patterns required for robust Revit API parameter handling, drawing from repository standards around exception handling and API safety practices.

Follow-up suggestions:

• @devloai fix the identified parameter null reference issues
• @devloai consider adding unit tests to validate parameter handling edge cases

...vit.tab/Drawing Set.panel/Sheets.pulldown/Copy Sheets to Open Documents.pushbutton/script.py

…ber.

czwangxtt

Fixed null check and exception handling.

...vit.tab/Drawing Set.panel/Sheets.pulldown/Copy Sheets to Open Documents.pushbutton/script.py

Copilot

Pull Request Overview

This PR enhances the "Copy Sheets to Open Documents" tool by adding a configurable option for preserving viewport detail numbers during sheet copying operations. The enhancement provides users with flexibility to either preserve original detail numbers or allow Revit to assign new ones, while adding robust error handling and improved logging.

Added a "Preserve Detail Numbers" checkbox option (defaulting to ON for backward compatibility)
Implemented error handling with try/catch blocks to prevent script failures when parameters are unavailable
Enhanced logging to provide detailed feedback on viewport processing outcomes

...vit.tab/Drawing Set.panel/Sheets.pulldown/Copy Sheets to Open Documents.pushbutton/script.py

…l/Sheets.pulldown/Copy Sheets to Open Documents.pushbutton/script.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jmcouffin

Good to go
thanks

github-actions · 2025-08-13T08:16:48Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25225+0806-wip

github-actions · 2025-08-13T16:39:43Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25225+1628-wip

github-actions · 2025-08-18T17:13:00Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25230+1701-wip

github-actions · 2025-08-20T08:35:21Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25232+0824-wip

github-actions · 2025-08-20T09:02:09Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25232+0848-wip

github-actions · 2025-08-20T09:10:37Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25232+0859-wip

github-actions · 2025-08-20T11:39:42Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25232+1126-wip

github-actions · 2025-08-20T14:03:38Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25232+1352-wip

github-actions · 2025-08-21T06:49:57Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25233+0639-wip

github-actions · 2025-08-21T14:45:06Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25233+1431-wip

github-actions · 2025-08-21T14:48:45Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25233+1438-wip

github-actions · 2025-08-25T08:33:26Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25237+0821-wip

github-actions · 2025-08-25T08:52:27Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25237+0841-wip

github-actions · 2025-08-25T11:35:08Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25237+1124-wip

github-actions · 2025-09-22T10:58:20Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25265+1047-wip

github-actions · 2025-09-23T08:16:32Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25266+0803-wip

github-actions · 2025-09-25T18:09:14Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25268+1757-wip

github-actions · 2025-09-26T13:49:47Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1336-wip

github-actions · 2025-09-26T14:45:41Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1431-wip

github-actions · 2025-09-26T14:49:03Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1436-wip

github-actions · 2025-09-26T18:35:25Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1822-wip

github-actions · 2025-09-28T17:31:51Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25271+1719-wip

github-actions · 2025-09-29T20:18:42Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2003-wip

github-actions · 2025-09-29T20:23:56Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2012-wip

github-actions · 2025-09-29T20:29:07Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2017-wip

github-actions · 2025-09-29T22:02:20Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2149-wip

github-actions · 2025-10-01T17:49:24Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25274+1734-wip

github-actions · 2025-10-04T14:38:07Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1425-wip

github-actions · 2025-10-04T14:40:50Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1427-wip

github-actions · 2025-10-06T22:12:23Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25279+2157-wip

github-actions · 2025-10-07T02:31:00Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+0218-wip

github-actions · 2025-10-07T11:08:38Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1054-wip

github-actions · 2025-10-07T11:10:43Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+1057-wip

github-actions · 2025-10-09T17:11:37Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25282+1656-wip

github-actions · 2025-10-10T01:54:39Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25283+0140-wip

github-actions · 2025-10-13T10:35:32Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25286+1022-wip

github-actions · 2025-10-14T09:18:30Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25287+0905-wip

github-actions · 2025-10-14T10:15:34Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25287+1000-wip

github-actions · 2025-10-15T06:28:46Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25288+0613-wip

github-actions · 2025-10-20T08:09:42Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+0755-wip

github-actions · 2025-10-20T08:41:04Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+0828-wip

github-actions · 2025-10-20T11:26:48Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+1113-wip

github-actions · 2025-10-20T12:48:12Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25293+1234-wip

github-actions · 2025-10-29T10:03:03Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25302+0949-wip

Add preserve detail number as an option.

30c56fa

Add preserve detail number as an option. Make the script more robust. Add more details to the log.

devloai bot reviewed Aug 11, 2025

View reviewed changes

czwangxtt added 2 commits August 11, 2025 14:26

Check detail number null before getting parameter.

9c584cf

Update exception handler to be more specific for assigning detail num…

d745dbd

…ber.

czwangxtt commented Aug 11, 2025

View reviewed changes

jmcouffin requested a review from Copilot August 11, 2025 19:33

jmcouffin added Enhancement Enhancement request [class->Improved #{number}: {title}] Tools Issues related to pyRevit commands [subsystem] labels Aug 11, 2025

Copilot AI reviewed Aug 11, 2025

View reviewed changes

czwangxtt and others added 5 commits August 12, 2025 10:09

Update extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.pane…

70f33a6

…l/Sheets.pulldown/Copy Sheets to Open Documents.pushbutton/script.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.pane…

fae0b64

…l/Sheets.pulldown/Copy Sheets to Open Documents.pushbutton/script.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update extensions/pyRevitTools.extension/pyRevit.tab/Drawing Set.pane…

609447b

…l/Sheets.pulldown/Copy Sheets to Open Documents.pushbutton/script.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update script.py

4951ce1

small logic fixes

817b11d

jmcouffin approved these changes Aug 13, 2025

View reviewed changes

jmcouffin merged commit 861087d into pyrevitlabs:develop Aug 13, 2025

Uh oh!

Conversation

czwangxtt commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Copy Sheets to Open Documents: add “Preserve detail numbers” option (default ON), safer param handling, and richer logs

Description

Changes

Why

Checklist

Related Issues

Additional Notes

Uh oh!

devloai bot left a comment

Choose a reason for hiding this comment

PR Summary:

Review Summary:

Follow-up suggestions:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

czwangxtt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmcouffin left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 13, 2025

Uh oh!

github-actions bot commented Aug 13, 2025

Uh oh!

github-actions bot commented Aug 18, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Sep 28, 2025

czwangxtt commented Aug 11, 2025 •

edited

Loading