Feature 2248 - Toggle Grid Bubbles By Direction by MohamedAsli · Pull Request #2738 · pyrevitlabs/pyRevit

MohamedAsli · 2025-07-30T09:37:38Z

Toggle Grid Bubbles by Direction Command

Description

This PR adds a command that replaces the existing "Toggle All Grid Bubbles in Current View".
It allows users to toggle all bubbles in the active view but also implements the logic to toggle by direction.
It uses two main classes to manage grids and the UI window.

Directionality is not directly accessible in the API, so I used the distance from the grid bounding box corners to determine the right/left and top/bottom bubbles, and also check if the grid is horizontal, vertical, and so on.

The current script successfully toggles vertical and horizontal grids that are aligned with the internal origin orientation, both in plan/ceiling and section/elevation views (3D intentionally discarded). The next step is to manage project north (if it exists) to consider grids in the rotated coordinate system rather than the internal origin system.

I managed the visibility toggles with events, to instantly see effects on the view (was a bit inspired by @thumDer and his 'show view range').
Can run on a selection of grids, if no selection collects all grids in active view.

You will understand the next sentence once you test the command :
I've tried to keep checkboxes and radiobuttons in the UI updated to match the view and vice versa. But I detected one side effect to this functionality > once we we check/uncheck all checkboxes, radiobuttons update and effectively toggle visibility of all bubbles, even those not initially handled (diagonal ones).

Need your feedback and comments!

Checklist

Before submitting your pull request, ensure the following requirements are met:

Code follows the PEP 8 style guide.
Code has been formatted with Black using the command:
Changes are tested and verified to work as expected.

Related Issues

#2248

Additional Notes

I made this back in June 2024 but did not have the time to push it.
I developed it in another repo back then, so the first commit brings a lot, sorry !

devloai

PR Summary:

This PR introduces a new "Toggle Grid Bubbles by Direction" command that enhances the existing grid bubble management functionality. It allows users to selectively toggle grid bubbles based on directional orientation (top, bottom, left, right) using a WPF dialog interface. The implementation uses grid bounding boxes to determine directional positioning and supports both selected grids and all visible grids in the active view.

Review Summary:

The core functionality is well-designed with good separation of concerns between the CustomGrids class and ToggleGridWindow UI. However, there are critical null reference vulnerabilities in the bounding box handling logic that need immediate attention. The code follows pyRevit patterns for transactions and event handling, but lacks proper defensive programming for API calls that can return null values.

Follow-up suggestions:

@devloai fix the null reference issues in the bounding box handling methods
@devloai consider adding error handling for edge cases like curved or multi-segment grids

...g Set.panel/views.stack/Views.pulldown/Toggle Grid Bubbles by Direction.pushbutton/script.py

...Set.panel/views.stack/Views.pulldown/Toggle Grid Bubbles by Direction.pushbutton/bundle.yaml

Copilot

Pull Request Overview

This PR adds a new command "Toggle Grid Bubbles by Direction" that enhances the existing grid bubble functionality by allowing users to selectively toggle grid bubbles based on their directional orientation (top, bottom, left, right). The feature provides a more granular approach compared to the existing "Toggle All Grid Bubbles in Current View" command.

Key changes:

Implements directional grid bubble toggling with UI controls for each direction
Adds logic to determine grid orientation and bubble positioning using bounding box calculations
Provides real-time UI updates with checkbox and radio button synchronization

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.

File	Description
bundle.yaml	Adds the new command to the Views pulldown menu with separators
ui.xaml	Creates the WPF interface with directional checkboxes and toggle controls
script.py	Implements the core logic for grid analysis, bubble management, and UI handling
bundle.yaml (pushbutton)	Defines tooltip localization and engine configuration

...g Set.panel/views.stack/Views.pulldown/Toggle Grid Bubbles by Direction.pushbutton/script.py

jmcouffin · 2025-07-30T10:29:14Z

@MohamedAsli Nice tool!
and great PR.

Please implement the review by our AI friends whenever it makes sense; I will test it afterwards.

…ary view mode is enabled and handle NoneType exception that may be raised with the boundingbox.Enabled property

MohamedAsli · 2025-07-30T15:27:54Z

Added bundle informations.
Handled the NoneType thing (which wasn't a real issue, as I prevented script to run with grids hidden, so never caught a NoneType while getting the boundingbox). But now the script runs even if grids are hidden. They are simply skipped.
I consider if they are temporarily or permanently hidden, the user doesn't mind whether bubbles are hidden or not (I may be wrong in some cases)

...Set.panel/views.stack/Views.pulldown/Toggle Grid Bubbles by Direction.pushbutton/bundle.yaml

jmcouffin · 2025-08-01T13:58:52Z

Great Job @MohamedAsli !

github-actions · 2025-08-01T14:12:37Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25213+1402-wip

github-actions · 2025-08-04T10:38:17Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25216+1027-wip

github-actions · 2025-08-04T14:41:06Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25216+1429-wip

github-actions · 2025-08-07T09:20:35Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25219+0909-wip

github-actions · 2025-08-07T14:05:33Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25219+1354-wip

github-actions · 2025-08-07T14:11:11Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25219+1400-wip

github-actions · 2025-08-07T14:16:33Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25219+1405-wip

github-actions · 2025-09-02T19:01:14Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25245+1846-wip

github-actions · 2025-09-03T09:07:19Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25246+0855-wip

github-actions · 2025-09-05T10:00:02Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25248+0948-wip

github-actions · 2025-09-08T08:09:39Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0758-wip

github-actions · 2025-09-08T08:17:09Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0805-wip

github-actions · 2025-09-08T08:39:12Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0824-wip

github-actions · 2025-09-09T17:11:54Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25252+1659-wip

github-actions · 2025-09-12T06:55:51Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25255+0644-wip

github-actions · 2025-09-12T09:22:42Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25255+0911-wip

github-actions · 2025-09-13T07:38:18Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25256+0727-wip

github-actions · 2025-09-15T15:01:36Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25258+1448-wip

github-actions · 2025-09-22T10:58:29Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25265+1047-wip

github-actions · 2025-09-23T08:16:41Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25266+0803-wip

github-actions · 2025-09-25T18:09:25Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25268+1757-wip

github-actions · 2025-09-26T13:49:55Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1336-wip

github-actions · 2025-09-26T14:45:49Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1431-wip

github-actions · 2025-09-26T14:49:12Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1436-wip

github-actions · 2025-09-26T18:35:34Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1822-wip

github-actions · 2025-09-28T17:31:59Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25271+1719-wip

github-actions · 2025-09-29T20:18:51Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2003-wip

github-actions · 2025-09-29T20:24:05Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2012-wip

github-actions · 2025-09-29T20:29:15Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2017-wip

github-actions · 2025-09-29T22:02:28Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2149-wip

github-actions · 2025-10-01T17:49:33Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25274+1734-wip

github-actions · 2025-10-04T14:38:14Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1425-wip

github-actions · 2025-10-04T14:40:59Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25277+1427-wip

github-actions · 2025-10-06T22:12:31Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25279+2157-wip

github-actions · 2025-10-07T02:31:08Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25280+0218-wip

github-actions · 2025-10-29T10:03:15Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25302+0949-wip

MohamedAsli added 7 commits July 29, 2025 21:16

Add toggle grids bubbles by direction

5797708

Update toggle grids bubbles

13f7f20

change french UI buttons to english

e23a0eb

implement clean ui creation, and clean script exit

62f3838

indention messup (tab to spaces), and reformat

5fe476a

rename ui buttons

2b173cd

run black

e631123

devloai bot reviewed Jul 30, 2025

View reviewed changes

jmcouffin requested a review from Copilot July 30, 2025 09:51

Copilot AI reviewed Jul 30, 2025

View reviewed changes

jmcouffin added New Feature New feature request [class->Implemented #{number}: {title}] Tools Issues related to pyRevit commands [subsystem] labels Jul 30, 2025

MohamedAsli added 2 commits July 30, 2025 17:02

skip temporarily and permanently hidden grids, proceed even if tempor…

14f6e1e

…ary view mode is enabled and handle NoneType exception that may be raised with the boundingbox.Enabled property

update bundle informations

e0b94bb

jmcouffin reviewed Jul 31, 2025

View reviewed changes

...Set.panel/views.stack/Views.pulldown/Toggle Grid Bubbles by Direction.pushbutton/bundle.yaml Show resolved Hide resolved

MohamedAsli added 3 commits July 31, 2025 14:03

rollback wrong bundle and update pushbutton bundle informations

58f26a5

Merge remote-tracking branch 'origin/feature-2248' into feature-2248

eb23cba

oops again, third time's the charm

6bdc68a

jmcouffin approved these changes Aug 1, 2025

View reviewed changes

jmcouffin merged commit e7b9644 into pyrevitlabs:develop Aug 1, 2025

MohamedAsli mentioned this pull request Sep 12, 2025

Prune old command 'Toggle Grid Bubbles in View' #2803

Merged

Uh oh!

Conversation

MohamedAsli commented Jul 30, 2025

Toggle Grid Bubbles by Direction Command

Description

Checklist

Related Issues

Additional Notes

Uh oh!

devloai bot left a comment

Choose a reason for hiding this comment

PR Summary:

Review Summary:

Follow-up suggestions:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmcouffin commented Jul 30, 2025

Uh oh!

MohamedAsli commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jmcouffin commented Aug 1, 2025

Uh oh!

github-actions bot commented Aug 1, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 3, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

github-actions bot commented Sep 13, 2025

Uh oh!

github-actions bot commented Sep 15, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

MohamedAsli commented Jul 30, 2025 •

edited

Loading