Enhance font replacement functionality in Revit families by jmcouffin · Pull Request #2723 · pyrevitlabs/pyRevit

jmcouffin · 2025-07-02T07:45:13Z

Description

Added regex support for case-insensitive font name replacement.
Implemented recursive updates for nested generic annotation families.
Improved error handling and logging during font updates.
Updated main script logic to handle font replacement in both family and project documents.

thanks to https://discourse.pyrevitlabs.io/u/denver-22 🚀

Checklist

Before submitting your pull request, ensure the following requirements are met:

Code follows the PEP 8 style guide.
Code has been formatted with Black using the command:
Changes are tested and verified to work as expected.

Related Issues

https://discourse.pyrevitlabs.io/t/font-replacement-suggested-changes/9216

- Added regex support for case-insensitive font name replacement. - Implemented recursive updates for nested generic annotation families. - Improved error handling and logging during font updates. - Updated main script logic to handle font replacement in both family and project documents.

devloai

PR Summary:

This PR enhances the font replacement functionality by adding:
• Regex support for case-insensitive font name replacement
• Recursive updates for nested generic annotation families
• Improved error handling and logging during font updates
• Support for both family and project document font replacement workflows

Review Summary:

I've identified several critical issues that need to be addressed before merging. The main concerns are: a document resource leak risk in nested family processing, Revit API compatibility issues with ElementId changes in newer versions, and a variable scope bug in exception handling. I utilized my knowledge of pyRevit's coding standards and Revit API version compatibility requirements to perform this review. Please provide feedback on this review which I'll incorporate for future reviews.

Follow-up suggestions:

• @devloai fix the identified issues in this PR
• @devloai add error recovery mechanisms for family loading failures

...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py

…t3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py Co-authored-by: devloai[bot] <168258904+devloai[bot]@users.noreply.github.com>

…d error handling

Copilot

Pull Request Overview

This PR enhances the font replacement script for Revit families by adding regex-based, case-insensitive renaming and recursive updates for nested generic annotation families, along with improved error handling and updated main logic to support both family and project documents.

Add rename_element_type_if_needed for regex-based, case-insensitive font name replacement.
Implement recursive traversal and updating of nested generic annotation families.
Improve error logging and expand main script to handle both family and project contexts.

Comments suppressed due to low confidence (2)

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py:3

The code calls FamilyLoaderOptionsHandler but it isn’t imported. Add an import, for example: from rpw import FamilyLoaderOptionsHandler (or the appropriate module) to prevent a NameError.

import re

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py:32

Using DB.Element.Name.GetValue and SetValue is nonstandard and may not work. It’s clearer and more reliable to use the ElementType’s Name property directly, e.g., current_name = element_type.Name and element_type.Name = new_name.

    current_name = DB.Element.Name.GetValue(element_type)

...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py

…t3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-07-02T08:17:08Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25183+0806-wip

github-actions · 2025-07-08T06:20:44Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25189+0609-wip

github-actions · 2025-07-23T08:01:59Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25204+0748-wip

github-actions · 2025-07-28T20:14:36Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25209+2004-wip

github-actions · 2025-07-30T13:06:02Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25211+1247-wip

github-actions · 2025-08-01T14:12:41Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25213+1402-wip

github-actions · 2025-08-04T10:38:20Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25216+1027-wip

github-actions · 2025-08-04T14:41:10Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25216+1429-wip

github-actions · 2025-08-07T09:20:40Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25219+0909-wip

github-actions · 2025-08-07T14:05:38Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25219+1354-wip

github-actions · 2025-08-07T14:11:16Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25219+1400-wip

github-actions · 2025-08-07T14:16:37Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25219+1405-wip

github-actions · 2025-08-07T14:31:28Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25219+1421-wip

github-actions · 2025-08-08T10:19:20Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25220+1008-wip

github-actions · 2025-08-13T08:16:59Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25225+0806-wip

github-actions · 2025-08-13T16:39:56Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25225+1628-wip

github-actions · 2025-08-28T17:56:18Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25240+1743-wip

github-actions · 2025-08-31T16:47:19Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25243+1636-wip

github-actions · 2025-08-31T16:50:04Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25243+1639-wip

github-actions · 2025-09-01T09:29:36Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25244+0918-wip

github-actions · 2025-09-02T06:51:20Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25245+0639-wip

github-actions · 2025-09-02T06:53:32Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25245+0642-wip

github-actions · 2025-09-02T19:01:19Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25245+1846-wip

github-actions · 2025-09-03T09:07:23Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25246+0855-wip

github-actions · 2025-09-05T10:00:06Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25248+0948-wip

github-actions · 2025-09-08T08:09:43Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0758-wip

github-actions · 2025-09-08T08:17:14Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0805-wip

github-actions · 2025-09-08T08:39:17Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0824-wip

github-actions · 2025-09-09T17:11:58Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25252+1659-wip

github-actions · 2025-09-12T06:55:55Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25255+0644-wip

github-actions · 2025-09-12T09:22:46Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25255+0911-wip

github-actions · 2025-09-13T07:38:21Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25256+0727-wip

github-actions · 2025-09-15T15:01:41Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25258+1448-wip

github-actions · 2025-09-22T10:58:33Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25265+1047-wip

github-actions · 2025-09-23T08:16:47Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25266+0803-wip

github-actions · 2025-09-25T18:09:32Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25268+1757-wip

github-actions · 2025-09-26T13:49:59Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1336-wip

github-actions · 2025-09-26T14:45:53Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1431-wip

github-actions · 2025-09-26T14:49:17Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1436-wip

github-actions · 2025-09-26T18:35:41Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25269+1822-wip

github-actions · 2025-09-28T17:32:02Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25271+1719-wip

github-actions · 2025-09-29T20:18:55Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2003-wip

github-actions · 2025-09-29T20:24:10Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2012-wip

github-actions · 2025-09-29T20:29:18Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2017-wip

github-actions · 2025-09-29T22:02:33Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25272+2149-wip

github-actions · 2025-10-29T10:03:20Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25302+0949-wip

jmcouffin added the Tools Issues related to pyRevit commands [subsystem] label Jul 2, 2025

jmcouffin requested a review from Copilot July 2, 2025 07:47

devloai bot reviewed Jul 2, 2025

View reviewed changes

Update extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/edi…

6b0838f

…t3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py Co-authored-by: devloai[bot] <168258904+devloai[bot]@users.noreply.github.com>

This comment was marked as outdated.

Sign in to view

jmcouffin added 2 commits July 2, 2025 09:56

Fix font replacement logic and improve nested family handling in Revit

922755d

Refactor nested family processing in font update function for improve…

ff50348

…d error handling

jmcouffin requested a review from Copilot July 2, 2025 07:59

jmcouffin marked this pull request as ready for review July 2, 2025 08:00

Copilot AI reviewed Jul 2, 2025

View reviewed changes

...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py Outdated Show resolved Hide resolved

Update extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/edi…

61fdd80

…t3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jmcouffin merged commit 1cba977 into develop Jul 2, 2025

jmcouffin deleted the fix/replace-fonts-improvment branch July 2, 2025 08:02

Uh oh!

Conversation

jmcouffin commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Related Issues

Uh oh!

devloai bot left a comment

Choose a reason for hiding this comment

PR Summary:

Review Summary:

Follow-up suggestions:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

github-actions bot commented Jul 8, 2025

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

github-actions bot commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

github-actions bot commented Aug 1, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 8, 2025

Uh oh!

github-actions bot commented Aug 13, 2025

Uh oh!

github-actions bot commented Aug 13, 2025

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

github-actions bot commented Sep 1, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 3, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

jmcouffin commented Jul 2, 2025 •

edited

Loading