fix adding clr Reference LibGit2Sharp to git.py#2706
Merged
Conversation
Totally unrelated to #2696 (comment)
Contributor
|
Unable to perform a code review. You have run out of credits 😔 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the way the clr reference for LibGit2Sharp is added in git.py to properly support IronPython environments.
- Updated the import statement to include IRONPY3 and IRONPY2.
- Adjusted the conditional logic to call clr.AddReferenceToFileAndPath for IronPython environments and fallback to clr.AddReference otherwise.
Comments suppressed due to low confidence (1)
pyrevitlib/pyrevit/coreutils/git.py:27
- [nitpick] Consider adding a comment explaining why IronPython (IRONPY3/IRONPY2) environments require using 'AddReferenceToFileAndPath' instead of the standard 'AddReference'.
if IRONPY3 or IRONPY2:
sanzoghenzo
requested changes
Jun 13, 2025
Contributor
sanzoghenzo
left a comment
There was a problem hiding this comment.
You can make it easier 😉
Co-authored-by: Andrea Ghensi <andrea.ghensi@gmail.com>
Co-authored-by: Andrea Ghensi <andrea.ghensi@gmail.com>
sanzoghenzo
approved these changes
Jun 13, 2025
Contributor
Author
|
Thanks for the review @sanzoghenzo |
Contributor
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1830-wip |
Contributor
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25171+0757-wip |
Contributor
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25181+1313-wip |
Contributor
|
📦 New public release are available for 5.2.0.25181+1425 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix adding clr Reference LibGit2Sharp to git.py
Related Issues
Totally unrelated to #2696 (comment)