Conversation
There was a problem hiding this comment.
PR Summary:
• Fixes Color Splasher tool not detecting MEP spaces and HVAC zones in recent versions
• Corrects string comparison from is to == for reliable IronPython behavior
• Replaces incorrect BuiltInCategoryFillScheme with proper ColorFillScheme API class
• Resolves issue #2684 where fewer elements were being detected compared to v4.8.16.24121
Review Summary:
Both fixes are correctly implemented and address the core issues identified in #2684. The string comparison fix ensures reliable behavior in IronPython, while the API class correction restores proper element detection for spaces and zones. Used repository knowledge about IronPython string handling and Revit API compatibility requirements. Please provide feedback on this review for future improvements.
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0920-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25155+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1125-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1306-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+2030-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+0700-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1347-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1420-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1830-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25171+0757-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25181+1313-wip |
|
📦 New public release are available for 5.2.0.25181+1425 |
Description
fixes properly #2684 (and #2690 I was too quick on the button 😄 )
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request: