Conversation
There was a problem hiding this comment.
PR Summary:
This PR adds a UTF-8 encoding declaration at the top of the script to fix issue #2669. The fix addresses a UnicodeEncodeError that occurred when the script encountered non-ASCII characters in filenames, particularly affecting users working with French characters.
Review Summary:
The change is straightforward and correctly addresses the reported issue. Adding the encoding declaration is the proper approach for handling international characters in Python, especially in IronPython 2.7 which is used by pyRevit. Your feedback on this review would be welcome for future reviews.
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0639-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25140+1615-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25141+1904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25143+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25146+0559-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1012-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1943-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25153+1459-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0858-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0920-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25155+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1125-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1306-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+2030-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+0700-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1347-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1420-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1830-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25171+0757-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25181+1313-wip |
|
📦 New public release are available for 5.2.0.25181+1425 |
Fixes #2669