Update Create Revised Sheet Set, to Give the users control to Set the…#2668
Update Create Revised Sheet Set, to Give the users control to Set the…#2668jmcouffin merged 2 commits intopyrevitlabs:developfrom
Conversation
… name of the set before creation I'm proposing to add a forms.ask_for_string prompt to the users to name their set in the fly instead of going there manually and name their revision after creation.
There was a problem hiding this comment.
PR Summary:
This PR enhances the "Create Revised Sheet Set" functionality by adding a prompt that allows users to name their revision sheet set before creation. Previously, users had to manually rename the set after creation, which required extra steps. The implementation adds a forms.ask_for_string prompt with a default name based on the selected revisions, improving workflow efficiency.
Review Summary:
The implementation correctly addresses the stated goal of giving users control over set naming. I've suggested a few improvements to make the code more robust and user-friendly, particularly around error handling and string manipulation. Your effort to streamline the revision sheet set workflow is much appreciated!
Please feel free to provide feedback on this review - I'll incorporate it into future reviews.
Follow-up suggestions:
@devloai implement the suggested improvements for more robust empty string handling and better error messages
...yRevit.tab/Drawing Set.panel/Revision.pulldown/Create Revised Sheet Set.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...yRevit.tab/Drawing Set.panel/Revision.pulldown/Create Revised Sheet Set.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...yRevit.tab/Drawing Set.panel/Revision.pulldown/Create Revised Sheet Set.pushbutton/script.py
Outdated
Show resolved
Hide resolved
|
Good addition, thanks @tay0thman |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0631-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0639-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25140+1615-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25141+1904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25143+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25146+0559-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1012-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1943-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25153+1459-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0858-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0920-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25155+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1125-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1306-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+2030-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+0700-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1347-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1420-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1830-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25171+0757-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25181+1313-wip |
|
📦 New public release are available for 5.2.0.25181+1425 |
… name of the set before creation
I'm proposing to add a forms.ask_for_string prompt to the users to name their set in the fly instead of going there manually and name their revision after creation.