Update "Generate Revision Report" Tool to give more control over whic…#2667
Update "Generate Revision Report" Tool to give more control over whic…#2667jmcouffin merged 3 commits intopyrevitlabs:developfrom
Conversation
…h Revisions to be reported This is a minor tweak requested by people around me where the Contractor asked for a quick report on what changed in a specific revision. I replaced the FilteredElementCollector with forms.select_revisions which will give the users more flexibility and control over their report.
There was a problem hiding this comment.
PR Summary:
This PR enhances the "Generate Revision Report" tool by replacing the FilteredElementCollector with forms.select_revisions. This change gives users more flexibility and control over which revisions to include in their report, making it easier to generate targeted reports for specific revisions as requested by contractors.
Review Summary:
The change is straightforward and improves user control over the report generation process. I've identified a couple of issues that need to be addressed before merging: a missing import statement and a potential edge case when users cancel the selection dialog. These fixes will ensure the tool works reliably in all scenarios.
Please feel free to provide feedback on this review - I'm happy to clarify any points or discuss alternative approaches.
Follow-up suggestions:
@devloai fix the identified issues in a follow-up commit
...yRevit.tab/Drawing Set.panel/Revision.pulldown/Generate Revision Report.pushbutton/script.py
Show resolved
Hide resolved
...yRevit.tab/Drawing Set.panel/Revision.pulldown/Generate Revision Report.pushbutton/script.py
Show resolved
Hide resolved
Add forms import Added script exit if no selection
|
Thanks again @tay0thman |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0631-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0639-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25140+1615-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25141+1904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25143+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25146+0559-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1012-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1943-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25153+1459-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0858-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0920-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25155+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1125-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1306-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+2030-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+0700-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1347-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1420-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1830-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25171+0757-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25181+1313-wip |
|
📦 New public release are available for 5.2.0.25181+1425 |
Tool to give more control on which Revisions to be reported
This is a minor tweak requested by people around me where the Contractor asked for a quick report on what changed in a specific revision.
I replaced the FilteredElementCollector with forms.select_revisions which will give the users more flexibility and control over their report.