Conversation
There was a problem hiding this comment.
PR Summary:
This PR introduces a Font Switcher tool that allows users to change fonts across multiple element types in a Revit project. The tool provides options to update fonts in:
- Families (including embedded text elements)
- Text Notes
- Dimensions
It features a user-friendly UI with font selection and element type filtering, along with progress tracking and detailed reporting of changes.
Review Summary:
The overall implementation is well-structured with good documentation. I've identified several areas for improvement related to error handling, document lifecycle management, and progress tracking. Addressing these issues will make the tool more robust and prevent potential memory leaks when working with family documents. I'm available to provide feedback on any questions related to these suggestions.
Follow-up suggestions:
@devloai improve family document handling with try-finally blocks to prevent memory leaks
...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py
Show resolved
Hide resolved
...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py
Show resolved
Hide resolved
...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py
Show resolved
Hide resolved
...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py
Show resolved
Hide resolved
...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new tool to switch fonts for Dimensions, Text Notes, and within project Families in a Revit environment.
- Added a new Python script to update font parameters in families, text note types, and dimension types.
- Integrated a ProgressBar for visual feedback during batch updates.
- Added a bundle YAML file with multilingual metadata to support localized tooltips and titles.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| script.py | Implements the font update logic for Revit Families, Text Note Types, and Dimension Types. |
| bundle.yaml | Provides localized metadata (titles and tooltips) for the font replacement tool. |
...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py
Show resolved
Hide resolved
...ension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/Replace_Fonts.pushbutton/script.py
Show resolved
Hide resolved
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25133+1246-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0631-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0639-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25140+1615-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25141+1904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25143+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25146+0559-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1012-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1943-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25153+1459-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0858-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0920-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25155+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1125-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1306-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+2030-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+0700-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1347-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1420-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1830-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25171+0757-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25181+1313-wip |
|
📦 New public release are available for 5.2.0.25181+1425 |
Tool: Font Switcher
Description
Tool to switch fonts in Dimensions, Text Notes and Inside project's Families
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}