Add "Associated to Others" to Wipe Family Parameters button#2644
Add "Associated to Others" to Wipe Family Parameters button#2644jmcouffin merged 4 commits intopyrevitlabs:developfrom
Conversation
|
Ah, I haven't noticed another pending PR to |
|
This should be fine. Let me review that on Monday. |
|
@devloai please review pr |
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- pyrevitlib/pyrevit/forms/FamilyParameterItemStyle.xaml: Language not supported
Comments suppressed due to low confidence (1)
pyrevitlib/pyrevit/forms/init.py:2042
- [nitpick] Consider renaming 'isassociated' to 'is_associated' to improve readability and follow common Python naming conventions.
self.isassociated = associated
There was a problem hiding this comment.
PR Summary:
This PR adds functionality to identify and filter parameters that are associated with other elements (such as connectors) in the "Wipe Family Parameters" tool. It adds a new include_associated parameter to forms.select_family_parameters(), makes the "Associated to Others" tag visible in the selection form, and adds it to the Parameter Filters dropdown. This addresses issue #2476 where users could accidentally delete parameters used by connectors.
Review Summary:
The implementation is clean and consistent with the existing codebase patterns. The code correctly identifies associated parameters using AssociatedParameters.IsEmpty and adds appropriate UI elements. My minor comments suggest documentation improvements to clarify what "associated parameters" means in this context. Feel free to provide feedback on this review for future improvements.
Follow-up suggestions:
@nodatasheet verify this works with your specific connector parameter use case
|
Nice work @nodatasheet |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25104+1041-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25104+1127-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25105+0957-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25106+0734-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1252-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1322-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1408-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25107+0621-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25116+1412-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25118+1113-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25119+1928-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25133+1246-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0631-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0639-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25140+1615-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25141+1904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25143+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25146+0559-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1012-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1943-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25153+1459-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0858-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0920-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25155+0904-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1125-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1306-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25162+2030-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+0700-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1347-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1420-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1830-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25171+0757-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25181+1313-wip |
|
📦 New public release are available for 5.2.0.25181+1425 |
Add "Associated to Others" to Wipe Family Parameters button
Description
include_associatedtoforms.select_family_parameters. Now it is possible to filter parameters that are associated to others.Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request:
Additional Notes
Thank you for contributing to pyRevit! 🎉