LibGit2Sharp missing CredentialsProvider fix by dnenov · Pull Request #2637 · pyrevitlabs/pyRevit

dnenov · 2025-04-09T14:48:36Z

LibGit2Sharp missing CredentialsProvider fix

Description

The purpose of this PR is to resolve a long-standing bug where using a different version of LibGit2Sharp library will produce the following error when trying to install an extension from a private GitHub repository:

The proposed fix is to check if the CredentialsProvider property exists in the current API and only provide it then.

Checklist

Before submitting your pull request, ensure the following requirements are met:

Code follows the PEP 8 style guide.
Code has been formatted with Black using the command:
```
pipenv run black {source_file_or_directory}
```
Changes are tested and verified to work as expected.

Related Issues

n/a

Additional Notes

currently runs into an error if using a different LibGit2Sharp version not expecting CredentialsProvider property

Reviewers

@jmcouffin

- currently runs into an error if using a different LibGit2Sharp version not expecting CredentialsProvider property

devloai · 2025-04-09T14:48:41Z

Unable to perform a code review. You have run out of credits 😔
You can buy additional credits from the subscription page.

dnenov · 2025-04-09T15:38:55Z

Hey @jmcouffin - I tried pushing a new PR with a small code fix, but ran into the above bot message: Unable to perform a code review. You have run out of credits 😔 You can buy additional credits from the [subscription page](https://devlo.ai/settings). Just flagging it up, I am not sure if there is a policy I need to abide by.

jmcouffin · 2025-04-09T16:43:09Z

Hey @jmcouffin - I tried pushing a new PR with a small code fix, but ran into the above bot message: Unable to perform a code review. You have run out of credits 😔 You can buy additional credits from the [subscription page](https://devlo.ai/settings). Just flagging it up, I am not sure if there is a policy I need to abide by.

Don't worry about it. 2 emails down I got a reply from devlo, I will either get new credits or remove it

Copilot

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

pyrevitlib/pyrevit/coreutils/git.py:131

Consider adding a test to verify that _make_clone_options correctly handles cases where CredentialsProvider is not supported by the API.

if username and password:

jmcouffin · 2025-04-09T16:51:41Z

Thanks @dnenov
The little things that matter most. That's a nice one. And clean!

github-actions · 2025-04-09T17:09:38Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25099+1655-wip

dnenov · 2025-04-10T14:37:45Z

Thanks @dnenov The little things that matter most. That's a nice one. And clean!

Thanks for the super flash review @jmcouffin! I followed the instructions in the template and the formatting changed slightly, I hope that was OK.

jmcouffin · 2025-04-10T14:47:14Z

I hope that was OK.

It is. Doing the formatting all at once on the codebase would be brutal.

github-actions · 2025-04-11T07:14:10Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25101+0700-wip

github-actions · 2025-04-11T15:17:05Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25101+1501-wip

github-actions · 2025-04-14T08:25:50Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25104+0813-wip

github-actions · 2025-04-14T10:28:25Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25104+1015-wip

github-actions · 2025-04-14T10:54:40Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25104+1041-wip

github-actions · 2025-04-14T11:40:45Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25104+1127-wip

github-actions · 2025-04-15T10:08:01Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25105+0957-wip

github-actions · 2025-04-16T07:48:27Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25106+0734-wip

github-actions · 2025-04-16T13:11:03Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1252-wip

github-actions · 2025-04-16T13:35:14Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1322-wip

github-actions · 2025-04-16T14:21:54Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25106+1408-wip

github-actions · 2025-04-17T06:35:28Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25107+0621-wip

github-actions · 2025-04-26T14:24:38Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25116+1412-wip

github-actions · 2025-04-28T11:27:29Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25118+1113-wip

github-actions · 2025-04-29T19:47:22Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25119+1928-wip

github-actions · 2025-05-13T13:03:39Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25133+1246-wip

github-actions · 2025-05-16T06:41:27Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0631-wip

github-actions · 2025-05-16T06:49:09Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25136+0639-wip

github-actions · 2025-05-20T16:30:33Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25140+1615-wip

github-actions · 2025-05-21T19:14:27Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25141+1904-wip

github-actions · 2025-05-23T09:16:55Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25143+0904-wip

github-actions · 2025-05-26T06:11:59Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25146+0559-wip

github-actions · 2025-05-29T10:25:27Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1012-wip

github-actions · 2025-05-29T19:56:56Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25149+1943-wip

github-actions · 2025-06-02T15:12:59Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25153+1459-wip

github-actions · 2025-06-03T09:08:47Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0858-wip

github-actions · 2025-06-03T09:30:57Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25154+0920-wip

github-actions · 2025-06-04T09:21:44Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25155+0904-wip

github-actions · 2025-06-11T11:39:58Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1125-wip

github-actions · 2025-06-11T13:16:49Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25162+1306-wip

github-actions · 2025-06-11T20:41:02Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25162+2030-wip

github-actions · 2025-06-13T07:10:27Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25164+0700-wip

github-actions · 2025-06-13T13:57:59Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1347-wip

github-actions · 2025-06-13T14:35:38Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1420-wip

github-actions · 2025-06-13T18:44:36Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25164+1830-wip

github-actions · 2025-06-20T08:09:15Z

📦 New work-in-progress (wip) builds are available for 5.1.0.25171+0757-wip

github-actions · 2025-06-30T13:25:55Z

📦 New work-in-progress (wip) builds are available for 5.2.0.25181+1313-wip

github-actions · 2025-06-30T13:44:50Z

📦 New public release are available for 5.2.0.25181+1425

dnenov added 2 commits April 9, 2025 15:20

_make_clone_options-fix

3119d39

- currently runs into an error if using a different LibGit2Sharp version not expecting CredentialsProvider property

formatted with black

bb50f89

pep8 format

246328c

jmcouffin requested a review from Copilot April 9, 2025 16:49

jmcouffin self-assigned this Apr 9, 2025

Copilot AI reviewed Apr 9, 2025

View reviewed changes

jmcouffin added the Extensions Issues related to pyRevit extensions [subsystem] label Apr 9, 2025

jmcouffin approved these changes Apr 9, 2025

View reviewed changes

jmcouffin merged commit 994705a into pyrevitlabs:develop Apr 9, 2025

TPJW mentioned this pull request Jul 25, 2025

[Bug]: CLI can't clone private or public GitHub Repos/Extensions #2590

Closed

5 tasks

Wurschdhaud mentioned this pull request Mar 15, 2026

[Bug]: installation of extensions from private repo is not working in the UI #2220

Closed

8 tasks

Uh oh!

Conversation

dnenov commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

LibGit2Sharp missing CredentialsProvider fix

Description

Checklist

Related Issues

Additional Notes

Reviewers

Uh oh!

devloai bot commented Apr 9, 2025

Uh oh!

dnenov commented Apr 9, 2025

Uh oh!

jmcouffin commented Apr 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

jmcouffin commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

dnenov commented Apr 10, 2025

Uh oh!

jmcouffin commented Apr 10, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 17, 2025

Uh oh!

github-actions bot commented Apr 26, 2025

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 16, 2025

Uh oh!

github-actions bot commented May 16, 2025

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

dnenov commented Apr 9, 2025 •

edited

Loading