fix #2604 - Select - Find and select entities without dimensions - Not working on Revit 2024#2618
Conversation
…t working on Revit 2024 fix #2604 - Select - Find and select entities without dimensions - Not working on Revit 2024
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #2604 by updating the script used to select entities without dimensions in Revit 2024. The changes include:
- Removing the dependency on get_elementid_value_func and using IntegerValue instead.
- Updating dictionary formatting and minor code style adjustments.
- Improving the alert message formatting for clarity.
There was a problem hiding this comment.
PR Summary:
This PR fixes issue #2604 where the 'Find and Select Entities Without Dimensions' tool wasn't working in Revit 2024. The core issue relates to ElementId handling differences in Revit 2024+ where the API changed from using ElementId.IntegerValue to ElementId.Value. The fix implements version-specific handling for this API change.
Review Summary:
The approach to fixing the ElementId handling for newer Revit versions is sound. I've identified a few areas for improvement, particularly ensuring consistent ElementId handling throughout the script. The PR demonstrates good understanding of the Revit API changes between versions.
Please provide feedback on this review which will help improve future reviews.
Follow-up suggestions:
@devloai apply the suggested changes to fix the potential ElementId handling issue at line 39
...elect.stack/Select.pulldown/Find And Select Entities Without Dimensions.pushbutton/script.py
Show resolved
Hide resolved
...elect.stack/Select.pulldown/Find And Select Entities Without Dimensions.pushbutton/script.py
Show resolved
Hide resolved
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25086+1637-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25090+0650-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25090+0707-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25092+0954-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25093+2001-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25094+0703-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25094+0800-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.1.25094+0926-wip |
|
📦 New work-in-progress (wip) builds are available for 5.1.0.25094+0940-wip |
|
📦 New public release are available for 5.1.0.25094+1133 |
|
📦 New public release are available for 5.1.0.25094+1133 |
|
📦 New public release are available for 5.1.0.25094+1133 |
fix #2604 - Select - Find and select entities without dimensions - Not working on Revit 2024