Skip to content

docs: make the text in the logo follow the site theme#2517

Merged
jmcouffin merged 1 commit intopyrevitlabs:developfrom
sanzoghenzo:logo-text-color
Jan 14, 2025
Merged

docs: make the text in the logo follow the site theme#2517
jmcouffin merged 1 commit intopyrevitlabs:developfrom
sanzoghenzo:logo-text-color

Conversation

@sanzoghenzo
Copy link
Copy Markdown
Contributor

this one was bugging me for a long time...
I use dark mode almost everywhere, and the logo in the README/main docs page rendered awfully.

I added the fill="currentColor" attribute to the SVG texts, but in order to make it work I had to directly insert the image inside the markdown file, so now there are 63 lines of undreadable garbage at the beginning of the .md file 😅

Up to you to decide if move this forward or not.

to check it locally, you can give the usual pipenv mkdocs serve command.

@sanzoghenzo sanzoghenzo requested a review from jmcouffin January 13, 2025 19:43
@jmcouffin
Copy link
Copy Markdown
Contributor

jmcouffin commented Jan 14, 2025

Question,
when building locally, I do have to pip install mkdocs before running pipenv mkdocs serve
shouldn't it be in the pipfile/requirements already?

pipenv run mkdocs serve

@jmcouffin jmcouffin merged commit 6c94474 into pyrevitlabs:develop Jan 14, 2025
@jmcouffin jmcouffin added the Wiki Issues related to Wiki or Documentation [subsystem] label Jan 14, 2025
@jmcouffin
Copy link
Copy Markdown
Contributor

ugly solution but efficient!
💯 appoved 😛

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25015+1341-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25015+1357-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25024+1520-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25024+1957-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25025+1310-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25030+1056-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25030+1130-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25030+1138-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25031+1700-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25032+1615-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25032+1635-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25032+1841-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25033+1337-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25033+1402-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25034+1241-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25034+1511-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

📦 New public release are available for 5.0.0.24174+2300

@sanzoghenzo sanzoghenzo deleted the logo-text-color branch February 9, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Wiki Issues related to Wiki or Documentation [subsystem]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants