Skip to content

Create CADAUDIT_check.py#2423

Merged
jmcouffin merged 5 commits intopyrevitlabs:Preflight-Checks_Hackathon_2024from
nasmovk:patch-1
Nov 4, 2024
Merged

Create CADAUDIT_check.py#2423
jmcouffin merged 5 commits intopyrevitlabs:Preflight-Checks_Hackathon_2024from
nasmovk:patch-1

Conversation

@nasmovk
Copy link
Copy Markdown
Contributor

@nasmovk nasmovk commented Oct 18, 2024

My proposal for a comprehensive audit of cad instances. See details described in the ModelChecker class comments. It would replace the old LISTDWGs by F. Beaupere, from the Project panel, link tools. Bonus: It also extends the basic functionality of RPW by adding radio buttons and a cancel button.

My proposal for a comprehensive audit of cad instances. See details described in the ModelChecker class comments.
It would replace the old LISTDWGs by F. Beaupere, from the Project panel, link tools.
Bonus: It also extends the basic functionality of RPW by adding radio buttons and a cancel button.
@jmcouffin
Copy link
Copy Markdown
Contributor

It also extends the basic functionality of RPW by adding radio buttons and a cancel button.

would be cool if you could add it to the rpw module and refer to it

@jmcouffin jmcouffin added the Extension Checks Issues related to pyRevit extension checks [subsystem] label Oct 18, 2024
@dosymep
Copy link
Copy Markdown
Member

dosymep commented Oct 18, 2024

please add screenshots or any results how to work your script, and maybe some demo file to check

@nasmovk
Copy link
Copy Markdown
Contributor Author

nasmovk commented Oct 19, 2024

CADAudit_check_samples.zip
@dosymep Sure.
The check starts like this:
image
Then you get a choice of run mode (using RPW with added radio buttons)
image
The output is in a table with clickable links back to the elements and a legend of explanations of the checks made and why.
image
There is some feedback on it in the forum:
https://discourse.pyrevitlabs.io/t/hackathon-preflight-checks-maker-fair/7702/8
Attached is a ZIP - a model with some linked CAD.

@nasmovk
Copy link
Copy Markdown
Contributor Author

nasmovk commented Oct 23, 2024

It also extends the basic functionality of RPW by adding radio buttons and a cancel button.

would be cool if you could add it to the rpw module and refer to it

Yes. I thought about doing that, but I didn't think it was allowed to change the built-in libraries. How would I do it? Make a PR on the RPW files in question?

@jmcouffin
Copy link
Copy Markdown
Contributor

@nasmovk yes, that and writing and adding it to the rpw test in the dev extension.

The rpw lib has been maintained mostly here by pyrevit users

@jmcouffin jmcouffin merged commit c771c27 into pyrevitlabs:Preflight-Checks_Hackathon_2024 Nov 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24338+2325-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24340+1616-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24340+1645-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24345+0715-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24351+0714-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24354+1726-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24364+2228-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24364+2256-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24365+2215-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25006+1041-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25009+2113-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25010+1021-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25010+1128-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1201-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1638-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1855-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1857-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25015+1341-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25015+1357-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25024+1520-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25024+1957-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25025+1310-wip

@nasmovk nasmovk deleted the patch-1 branch January 30, 2025 10:49
@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25030+1056-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25030+1130-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25030+1138-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.25031+1700-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25032+1615-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25032+1635-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25032+1841-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25033+1337-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25033+1402-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25034+1241-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

📦 New work-in-progress (wip) builds are available for 5.0.0.25034+1511-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

📦 New public release are available for 5.0.0.24174+2300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extension Checks Issues related to pyRevit extension checks [subsystem]

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants