Skip to content

New Tool - Move Viewport label#2387

Merged
jmcouffin merged 9 commits intopyrevitlabs:developfrom
jmcouffin:tool_move_vp_label
Sep 2, 2024
Merged

New Tool - Move Viewport label#2387
jmcouffin merged 9 commits intopyrevitlabs:developfrom
jmcouffin:tool_move_vp_label

Conversation

@jmcouffin
Copy link
Copy Markdown
Contributor

@jmcouffin jmcouffin added the Tools Issues related to pyRevit commands [subsystem] label Sep 2, 2024
Copy link
Copy Markdown
Contributor

@sanzoghenzo sanzoghenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be those that use the pyrevit library properly 😉

As stated in the latest comment, this needs proper error handling.

Copy link
Copy Markdown
Contributor

@sanzoghenzo sanzoghenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll stop here, other thing I would add are just because of personal preference, so they are not needed.

I suppose that after those two changes we could wrap it up

Copy link
Copy Markdown
Contributor

@sanzoghenzo sanzoghenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one, I promise 😉

@jmcouffin
Copy link
Copy Markdown
Contributor Author

@sanzoghenzo thanks for the review. Really enjoyed it!

@jmcouffin jmcouffin merged commit 0b2260f into pyrevitlabs:develop Sep 2, 2024
@jmcouffin jmcouffin deleted the tool_move_vp_label branch September 2, 2024 14:06
@jmcouffin jmcouffin restored the tool_move_vp_label branch September 2, 2024 14:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 2, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24246+1410-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24253+1920-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24254+1158-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24254+1351-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24261+0647-wip

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24281+2116-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24293+1618-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24294+1030-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24295+0909-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New public release are available for 5.0.0.24174+2300

@jmcouffin jmcouffin deleted the tool_move_vp_label branch January 7, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools Issues related to pyRevit commands [subsystem]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants