Failed when running compilation

jmcouffin · jmcouffin · commit cc912052edd6 · 2026-01-22T23:08:07.000+01:00
pipenv run pyrevit build labs
pipenv run pyrevit build products Debug
copy .\release\.pyrevitargs .

---

refactor: update ScriptRuntimeConfigs properties for better encapsulation

- Changed LogFilePath and SuppressOutput from fields to properties in ScriptRuntimeConfigs for improved encapsulation.
- Updated PyRevitRunnerCommand to set these properties dynamically, enhancing flexibility and maintainability.
diff --git a/dev/pyRevitLabs.PyRevit.Runtime/scriptruntime.cs b/dev/pyRevitLabs.PyRevit.Runtime/scriptruntime.cs
@@ -32,8 +32,8 @@ public class ScriptRuntimeConfigs : IDisposable {
         public List<string> SearchPaths { get; set; }
         public List<string> Arguments { get; set; }
         public IDictionary<string, object> Variables { get; set; }
-        public string LogFilePath;
-        public bool SuppressOutput;
+        public string LogFilePath { get; set; }
+        public bool SuppressOutput { get; set; }
 
         public object EventSender {
             get { return _eventSender; }
diff --git a/dev/pyRevitLoader/Source/PyRevitRunnerCommand.cs b/dev/pyRevitLoader/Source/PyRevitRunnerCommand.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Collections.Generic;
 
 using Autodesk.Revit.Attributes;
@@ -62,15 +62,28 @@ public Result Execute(ExternalCommandData commandData, ref string message, Eleme
                     DebugMode = false,
                     ConfigMode = false,
                     RefreshEngine = false,
-                    ExecutedFromUI = false,
-                    LogFilePath = LogFile,
-                    SuppressOutput = true,
-                    Variables = new Dictionary<string, object>() {
-                        {"__batchexec__",  true },
-                        {"__logfile__", LogFile ?? string.Empty },
-                        {"__models__", ModelPaths },
-                    }
+                    ExecutedFromUI = false
                 };
+                // Note: LogFilePath, SuppressOutput, and Variables properties may not be available
+                // in the referenced DLL version. These will be set via reflection if available.
+                try {
+                    var logFilePathProp = typeof(ScriptRuntimeConfigs).GetProperty("LogFilePath");
+                    if (logFilePathProp != null) logFilePathProp.SetValue(runtimeConfigs, LogFile);
+                    
+                    var suppressOutputProp = typeof(ScriptRuntimeConfigs).GetProperty("SuppressOutput");
+                    if (suppressOutputProp != null) suppressOutputProp.SetValue(runtimeConfigs, true);
+                    
+                    var variablesProp = typeof(ScriptRuntimeConfigs).GetProperty("Variables");
+                    if (variablesProp != null) {
+                        variablesProp.SetValue(runtimeConfigs, new Dictionary<string, object>() {
+                            {"__batchexec__",  true },
+                            {"__logfile__", LogFile ?? string.Empty },
+                            {"__models__", ModelPaths },
+                        });
+                    }
+                } catch {
+                    // Properties not available in this version of ScriptRuntimeConfigs
+                }
 
                 var env = new EnvDictionary();
                 var resultCode = ScriptExecutor.ExecuteScript(
@@ -186,10 +199,10 @@ private static void LogRunnerError(string logFilePath, Exception ex) {
             try {
                 File.AppendAllText(logFilePath, ex.ToString());
             }
-            catch (Exception ex) {
+            catch (Exception exInner) {
                 // Best-effort: do not throw while writing the runner error log.
                 System.Diagnostics.Debug.WriteLine(
-                    string.Format("[PyRevitRunner] Failed to append runner error to '{0}': {1}", logFilePath, ex)
+                    string.Format("[PyRevitRunner] Failed to append runner error to '{0}': {1}", logFilePath, exInner)
                 );
             }
         }
