Skip to content

Decryption of salt encrypted attributes (encrypt=2) is incorrect #194

@Thrushbeard

Description

@Thrushbeard

A cleartext value is wrong for salt encrypted attributes in a RADIUS packet (e.g. MS-CHAP2 MPPE keys).

There are two points about a hash value:

  1. Decryption and encryption functions are not completely the same. The hash must use part of an encrypted value, not a decrypted one

last = result[-16:]

last = data[:16] for the decryption.

  1. The initial hash value must use a request packet authenticator, not a reply packet authenticator

last = self.authenticator + salt

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions