Fix duplicate menus in GradientEditorItem#444
Fix duplicate menus in GradientEditorItem#444j9ac9k merged 3 commits intopyqtgraph:developfrom zachlowry:duplicate-menus
Conversation
Add call to ev.accept in Tivk.mouseClickEvent to prevent parent menu from opening on a right click of a Tick.
Codecov Report
@@ Coverage Diff @@
## develop #444 +/- ##
==========================================
+ Coverage 34.36% 35.66% +1.3%
==========================================
Files 198 198
Lines 27334 27335 +1
Branches 4555 4555
==========================================
+ Hits 9393 9749 +356
+ Misses 17083 16712 -371
- Partials 858 874 +16
Continue to review full report at Codecov.
|
2xB
left a comment
There was a problem hiding this comment.
With this change, both lines 868 and 877 accept the event. How about switching lines 867 and 868 (the if statement and ev.accept()) and removing line 877 (the new ev.accept())?
|
blerg, you would think i would have figured out how to do this without messing up people's branches... sorry about that @zachlowry I'll try and get this cleaned up |
|
Thanks for the PR @zachlowry sorry it's taken us so long to get this merged. |
Add call to ev.accept in Tivk.mouseClickEvent to prevent parent menu from opening on a right click of a Tick.