render comparison: resize before show#3415
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Nov 15, 2025
Merged
Conversation
this works around an issue when running on wayland on certain platforms. when resize occurs after the show, the window did not shrink, leading to image comparison test failures.
there's no point in instantiating a GraphicsLayoutWidget, only to immediately replace its central widget.
Contributor
Author
|
The same unfortunately can't be done for |
Member
|
Thanks @pijyoi ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around an issue when running on Wayland on certain platforms.
When resize occurs after the show, the window did not shrink, leading to image comparison test failures in the test suite.
Wayland platforms where the test failed.
Wayland platforms where the test didn't fail.
On the platforms where the tests failed, setting
QT_QPA_PLATFORM=xcbmade it pass.With this change, there are no longer any users of
ui_testing.py::resizeWindow.More context:
test_ROI.pyuses aGraphicsViewand was the only user ofresizeWindow.Other tests like
test_PlotCurveItem.py,test_NonUniformImage.py,test_ImageItem.pymake use ofGraphicsLayoutWidget.The first 2 resize their window before show, but the last one shows before resizing.