allow returned camera params to be set back#3408
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Nov 15, 2025
Merged
Conversation
Member
|
Love to see the 3D stuff get some attention, thanks @pijyoi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return value of
cameraParams()should be usable to restore the camera state.Before this PR, the following would need to be done
After this PR, the following will work
fixes #3407
Additional fixes:
reset()did not reset the default inquaternionmode.NOTES:
rotationMode, eitherrotationor (elevation,azimuth) can be used to modify camera params. However,rotationModedetermines which internal state gets modified.