Correctly handle SI-prefixes for nonlinear units#3394
Merged
j9ac9k merged 5 commits intopyqtgraph:masterfrom Nov 15, 2025
Merged
Correctly handle SI-prefixes for nonlinear units#3394j9ac9k merged 5 commits intopyqtgraph:masterfrom
j9ac9k merged 5 commits intopyqtgraph:masterfrom
Conversation
campagnola
reviewed
Oct 23, 2025
Member
|
This looks great to me, @oyvindlr! Thanks for adding the unit tests as well. |
Member
|
Whoops, I mishandled the merge ... let me fix that. |
9b5b0af to
346a5b7
Compare
Member
|
Thanks for the PR @oyvindlr ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where your unit has a power different from 1, the SI-prefix scaling becomes incorrect. For instance, 1000 m² will be shown as 1 km², which is off by a factor of 1000. And 1000 s^(-1) certainly is not 1 ks^(-1).
I've implemented a "unitPower" parameter that can be used when creating an axis label. The parameter will work for any power, positive, negative and non-integral.
Fixes #3389 and #3392