invalidate nan locations when downsampling image#3368
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 2, 2025
Merged
invalidate nan locations when downsampling image#3368j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
Contributor
|
Yes, sorry I never got around to testing this. You know how things are. Instead I just disabled autodownsampling, even for large images. I haven't really noticed any performance degradation from this. I'm confident @pijyoi has fixed the issue though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ImageItem downsampling factors to use are automatically re-calculated as the user makes changes to the view transform. E.g. zooming, changing window dimensions.
This means that any cached nan locations need to be invalidated.
May fix #3138
MWE that demonstrates the issue. The image dimensions used will trigger auto downsampling.