fix: blockSignal=True in Parameter.setValue()#3305
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Nov 15, 2025
Merged
Conversation
The behavior of blockSignal isn't specified, but other uses appear to use None/True. The previous implementation allowed to block a specific signal, but I'd expect most would want to block all signals.
Member
|
Ahh yeah, checking for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change to the Parameter.setValue() API.
The behaviour of blockSignal isn't specified, but other uses appear to use None/True. The previous implementation allowed to block a specific signal, but I'd expect most would want to block all signals.
This could be renamed to blockSignals to be more consistent with restoreState().
Both blockSignal and blockSignals could be included as kwargs to maintain both behaviours.