Emit sigRegionChanged only once for LinearRegionItem#3291
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Mar 31, 2025
Merged
Emit sigRegionChanged only once for LinearRegionItem#3291j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
|
Ha, I completely forgot about this, this was one of the first bugs I recognized in the library when I first started using it... Never got around to fixing it (or opening an issue it would seem). Thanks for the PR @jdranczewski |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinearRegionItemcurrently firessigRegionChangedthree times whensetRegionis used. This seems to be due to theblockLineSignalflag being cleared too early.I propose to move the flag lower down to fix this - in my testing this results in the signal being fired once instead of thrice.
Minimal code that reproduces this issue in pyqtgraph-0.13.7: