Fix parameter item compare unpack order#3264
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Mar 4, 2025
Merged
Conversation
a1807cb to
492969d
Compare
Member
Author
|
Decided since we have a difference in behavior from |
492969d to
d6d5832
Compare
d6d5832 to
1a9b05f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3229
Thank you @Qi-henry for reporting the issue and diagnosing the cause. Added a test case that caught this error.
Funny enough, this error did not occur when using
strtypes for values instead ofinttypes.