Merged
Conversation
set is unordered
non-macOS platforms do not reflect a width limit of [1, 1] when they are switched to Core Forward Compatible profiles. (ignoring for the moment that non-macOS platforms do not need to be set to Forward Compatible...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression was introduced in 1768175. The bug gets triggered if a
GLGraphItemusespxMode=False.In the original code, the view would be queried from the parent if the
GLScatterPlotItemdidn't have a view itself. This adhoc logic was implemented by Implement a GLGraphItem according to #807 #1721, in the very first implementation ofGLGraphItem. i.e.GLGraphItemwas the firstGLGraphicsItemto useGLScatterPlotItemas a child.The fix is to implement
GLGraphicsItem::view()such that it will automatically return the top level object's view for all its children.GLGraphicsItemwas storing its children in an unordered set. Thus for anyGLGraphicsItemwith more than 1 child, the rendering would occur in a random order from run-to-run. This includesGLGraphItem, which has 2 children.For non-macOS platforms set to Core Forward Compatible profiles, the logic to clamp widths to the permitted range failed. By definition, Core Forward Compatible profiles support only widths of 1.0. For all other profiles, it is not an error to provide a (positive) line width that is out of range. The driver will just clamp the value to its supported range.