fix GLIsosurface overflow warning on numpy 2#3235
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Feb 3, 2025
Merged
Conversation
shift[j] is of dtype uint16 and does have a value of 0 for certain iterations. a subtraction of 1 can thus cause an overflow depending on the numpy version. in numpy < 2.0, shift[j] is automatically promoted to an int32 prior to the subtraction and thus no overflow occurs. (i.e. pyqtgraph was relying on this behavior) in numpy >= 2.0, shift[j] remains as an uint16 and an overflow occurs.
GLMeshItem does not support correctly the combination of setFaceColors() and smooth=True.
Member
|
Thanks @pijyoi ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg.isosurface()relies on NumPy < 2.0 promotion behavior.An overflow warning occurs on NumPy >= 2.0.
Fix by explicitly promoting to an
int.