GLMeshItem: allow ubyte color buffers#3231
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Jan 28, 2025
Merged
Conversation
Member
|
Thanks @pijyoi for this PR! Wonderful to see more expanding compatibility within the opengl codepaths! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When specifying colors for a large number of vertices, keeping colors as
float32(16-bytes) instead ofuint8(4-bytes) can be wasteful in memory and bandwidth.Furthermore,
trimeshcolors are retrieved asuint8, which then requires conversion before being able to be used inpyqtgraph. (See the example in #3230)MeshDatadoesn't do any computation on the colors besides indexing and reshaping. i.e. it is actually agnostic to the dtype.GLMeshItemonly needs to tell OpenGL whether the VBO is float32 or uint8.