GLLinePlotItem: restore changes to state#3223
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Jan 25, 2025
Merged
Conversation
Member
|
Thanks for the PR @pijyoi love to see the OpenGL support keep improving ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: when running the
GLMeshItemexample, the line edges and wireframe can be seen to be thicker than before (e.g. 0.13.7)Reason:
Drawing the grid enables anti-aliasing which is not disabled after. Thus when drawing the edges of the meshes, anti-aliasing is also enabled, where previously it was not.
For compatibility with OpenGL ES and also Core profile, ecab72b removed calls to
glPushAttribandglPopAttrib. Those calls wrapped around the rendering of eachGLGraphicsItem, effectively allowing each item to make changes to the global OpenGL state without restoring them.Fix:
Restore the global state to their initial defaults in
GLLinePlotItem.