fixed the issue where x and y column would be added regardless of the columnMode while exporting to csv#3215
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Mar 24, 2025
Conversation
…e columnMode while exporting to csv
ixjlyons
reviewed
Jan 12, 2025
Member
ixjlyons
left a comment
There was a problem hiding this comment.
Looks good to me.
It'd be nice to have a test - would you be interested in adding a test with the (x,y,y,y) option to tests/exporters/test_csv.py?
Member
|
Closing and Opening to trigger a new CI run. |
Member
|
Thanks for the PR @virgile-hernicot ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
fixed the issue where x and y column would be added regardless of the columnMode while exporting to csv.
Basically fixes #2747.
Tested environment(s)
PyQtGraph version: pyqtgraph-0.13.7
Qt Python binding: PyQT6
Python version: 3.12.7
NumPy version: 2.1.2
Operating system: Windows 11