Fix bug causing DateTimeAxis to not display tick labels #3185#3187
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Jan 25, 2025
Merged
Fix bug causing DateTimeAxis to not display tick labels #3185#3187j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Contributor
|
Just want to mention that I am experiencing the same issue and would be happy if it this PR is merged. |
Member
|
Thanks for the PR @tblum I didn't realize the floating point errors with the use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request fixes the tick-labels not being displayed part of Issue #3185
I found that the bug in due to a floating point rounding error, which is not being taken into account in the QRectF.contains method. But the equality operator does take floating point rounding into account.
Demonstration of floating point rounding errer and work-around using
intersectedand==